Refactor to move files out of /pkg and fix import cycle #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lenny-intel <[email protected]>
lenny-goodell
force-pushed
the
FileRefactor
branch
from
e44bfba to
72dc35a
Compare
|
The addition of explicit ignoring of return types looks weird. But after reviewing the two links below, it looks like the way the Go language is moving -- albeit in potentially a less verbose way. |
tsconn23
approved these changes
Mar 28, 2019
|
@tsconn23 , yea that was me fixing things flagged by Goland to get that pretty green checkmark... ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #5
Files in
/pkgwere improperly importing/internalpackages. Movedinterface.go&factory.gotoregistryfolder at root and move structs out ofinterface.goto fiximport cycleissue. Refactored code for newtypesnamespace. Also some unit test code clean-up to explicitly ignore return values so IDE is happy.