[bug-OpenMage#436] Undefined var $k in Mage_Core_Model_Url_Rewrite::removeTag()

edannenberg · edannenberg · commit 541bbc51fd8f · 2020-08-17T11:24:30.000+02:00
diff --git a/app/code/core/Mage/Core/Model/Url/Rewrite.php b/app/code/core/Mage/Core/Model/Url/Rewrite.php
@@ -171,7 +171,7 @@ public function removeTag($tags)
 
         $removeTags = is_array($tags) ? $tags : explode(',', $tags);
 
-        foreach ($removeTags as $t) {
+        foreach ($removeTags as $k=>$t) {
             if (!is_numeric($k)) {
                 $t = $k.'='.$t;
             }

Original file line number	Diff line number	Diff line change
`@@ -171,7 +171,7 @@ public function removeTag($tags)`
`171`	`171`
`172`	`172`	`$removeTags = is_array($tags) ? $tags : explode(',', $tags);`
`173`	`173`
`174`		`- foreach ($removeTags as $t) {`
	`174`	`+ foreach ($removeTags as $k=>$t) {`
`175`	`175`	`if (!is_numeric($k)) {`
`176`	`176`	`$t = $k.'='.$t;`
`177`	`177`	`}`