Sanitize package versions that contains metadata #290
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In semver's summary we can find that:
Later on, they describe what that build metadata is: https://semver.org/#spec-item-10
This is the first time that I've seen this in the wild but it seems that some packages are using that and I actually had a need to patch such a package 😅
My
yarn.lock
for this items looks this:And the
.version
that I'm sanitizing as part of this PR is coming from the actualpackage.json
file - so it contains that build metadata.I'd like to write tests for this but I see that you are using property testing and while I know about the concept I've never actually written any such test. I'm eager to learn but would love some guidance - what would be the best place to add it? Any other tips?