Duplicate code, not matching comment #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

gomain opened this issue Sep 8, 2020 · 0 comments · Fixed by #258

Contributor

gomain commented Sep 8, 2020

patch-package/src/makePatch.ts

Lines 186 to 189 in 50f73bd

    
           // remove nested node_modules just to be safe 
        
           rimraf(join(tmpRepoPackagePath, "node_modules")) 
        
           // remove .git just to be safe 
        
           rimraf(join(tmpRepoPackagePath, "node_modules"))

Line 189 was probably meant to be

- rimraf(join(tmpRepoPackagePath, "node_modules"))
+ rimraf(join(tmpRepoPackagePath, ".git"))

gomain mentioned this issue

fix: not remove .git from tmpRepoPackagePath when creating patches #258

Merged

ds300 closed this as completed in #258

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment