Skip to content

Fix typos/grammar in concept.rst #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 12, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/pages/concept.rst
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ To use typeclasses you should understand these steps:
F2 --> F3["Calling"]

Let's walk through this process step by step.
The first on is "Typeclass definition", where we create a new typeclass:
The first one is "Typeclass definition", where we create a new typeclass:

.. code:: python

Expand Down Expand Up @@ -174,7 +174,7 @@ This registry is using ``isinstance`` function
to find handler that fits the defined predicate.
It has the highest priority among other dispatch methods.

This allows to sync both runtime and ``mypy`` behavior:
This allows us to sync both runtime and ``mypy`` behavior:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either of two options:

  • This allows syncing ...
  • This allows us/one to sync ...

https://ell.stackexchange.com/a/11197


.. code:: python

Expand Down Expand Up @@ -361,7 +361,7 @@ Overriding and extending existing instances

Sometimes we really need to override how things work.
With objects and classes this can be problematic,
because we would need to definie a new subclass
because we would need to define a new subclass
and chances are that it won't be used in some situations.

With ``@typeclass`` overriding something is as easy.
Expand Down