Issue #2804227 Add $order->getBalance() #786
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ddPayment, ::subtractPayment.
…payment entities.
|
I added one more change. Now when we calculate the balance, we consider the payment status. The tests are also updated for this. So I think this is now RTBC, but will wait for someone else to review it. |
This was referenced Sep 12, 2017
|
Looking good! Needs a rebase. |
|
I rebased this branch and put it up for testing at #821. I feel like I may have munged up a commit or two, so let's see.. |
|
Continued on the issue https://www.drupal.org/node/2804227 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase of PR 508. Adding a commerce_order_post_update_6() function.