Session.merge return type should be the type of the instance passed #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

JukkaL merged 1 commit into dropbox:master from DeanWay:session-merge-result

Jan 8, 2021

Contributor

DeanWay commented Jul 21, 2020

see: https://docs.sqlalchemy.org/en/13/orm/session_api.html#sqlalchemy.orm.session.Session.merge
"""
... The state of each attribute on the source instance is then copied to the target instance. The resulting target instance is then returned by the method ...
"""


          session merge should an object of the type passed.

70642b2

wbolster approved these changes

View reviewed changes

JukkaL approved these changes

View reviewed changes

Contributor

JukkaL left a comment

Looks good to me.

JukkaL merged commit f31c9da into dropbox:master

brabadu pushed a commit to brabadu/sqlalchemy-stubs that referenced this pull request


          Session merge should an object of the type passed (dropbox#165)

ecf0f6e

See: https://docs.sqlalchemy.org/en/13/orm/session_api.html#sqlalchemy.orm.session.Session.merge

Quote:

... The state of each attribute on the source instance is then copied to the target instance. The 
resulting target instance is then returned by the method ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet