Skip to content

Validate webhook using signature header in Gitea #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 23, 2019
Merged

Validate webhook using signature header in Gitea #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
aa4d209
validate webhook using signature header in Gitea
techknowlogick May 15, 2019
27a3ecd
Update webhook.go
techknowlogick May 15, 2019
7d85ece
Update webhook.go
techknowlogick May 15, 2019
7a85fe3
Update webhook.go
techknowlogick May 15, 2019
310a158
Update webhook.go
techknowlogick May 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion scm/driver/gitea/webhook.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,15 @@
package gitea

import (
"crypto/sha256"
"encoding/json"
"fmt"
"io"
"io/ioutil"
"net/http"

"github.com/drone/go-scm/scm"
"github.com/drone/go-scm/scm/driver/internal/hmac"
)

type webhookService struct {
Expand Down Expand Up @@ -58,7 +60,20 @@ func (s *webhookService) Parse(req *http.Request, fn scm.SecretFunc) (scm.Webhoo
}

secret := req.FormValue("secret")
if secret != key {
signature := req.Header.Get("X-Gitea-Signature")

// fail if no signature passed
if signature == "" && secret == "" {
return hook, scm.ErrSignatureInvalid
}

// test signature if header not set and secret is in payload
if signature == "" && secret != "" && secret != key {
return hook, scm.ErrSignatureInvalid
}

// test signature using header
if signature != "" && !hmac.Validate(sha256.New, data, []byte(key), signature) {
return hook, scm.ErrSignatureInvalid
}

Expand Down
2 changes: 2 additions & 0 deletions scm/driver/gitea/webhook_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,7 @@ func TestWebhookInvalid(t *testing.T) {
r, _ := http.NewRequest("GET", "/?secert=xxxxxxinvalidxxxxx", bytes.NewBuffer(f))
r.Header.Set("X-Gitea-Event", "pull_request")
r.Header.Set("X-Gitea-Delivery", "ee8d97b4-1479-43f1-9cac-fbbd1b80da55")
r.Header.Set("X-Gitea-Signature", "failfailfailfail")

s := new(webhookService)
_, err := s.Parse(r, secretFunc)
Expand All @@ -205,6 +206,7 @@ func TestWebhook_Validated(t *testing.T) {
r, _ := http.NewRequest("GET", "/?secret=71295b197fa25f4356d2fb9965df3f2379d903d7", bytes.NewBuffer(f))
r.Header.Set("X-Gitea-Event", "pull_request")
r.Header.Set("X-Gitea-Delivery", "ee8d97b4-1479-43f1-9cac-fbbd1b80da55")
r.Header.Set("X-Gitea-Signature", "a31111f057bafe895837f4a93c0f1f528919c199a20438b1fc8e23485780a33a")

s := new(webhookService)
_, err := s.Parse(r, secretFunc)
Expand Down