Remove AudioCVT, remove CVec from audio #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* CString has moved to `std::ffi` and has a new interface. * CVec has been removed entirely.
Working with `*const c_char` now works as follows: * Call `c_str_to_bytes(*const char)` helper function to get a slice of data w/o the null terminator. (`&'a [u8]`) * Use that slice of data to construct a standard `String` using the checked, unchecked, or lossy UTF-8 conversion methods. --- CString now only exists to go the other way (from String -> CString). It simply adds the invariants that the string contains no interior NULL bytes and has a null-terminator.
Unnecessary / incorrect imports because it's not being built in-tree.
* Several feature gates have been added to the language, yay! * raw_pointer_deriving -> raw_pointer_derive * #![macro_escape] -> #[macro_use]
drbawb
added a commit
that referenced
this pull request
Jan 7, 2015
Merge CString fixes, Remove AudioCVT, remove CVec from audio
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CVec is removed from the
audiosystem completely, as detailed in issue Rust-SDL2#267.While attempting to write a unit test for
AudioCVT, I was running into weird buffer-overflow issues. Instead of fighting with it, I removed it for now.AudioSpecWAVnow owns the audio buffer, and is freed ondrop().I also took the liberty to add an integration test for
AudioSpecWAV, in order to test that it actually works. :)Enjoy!