fix: memcached operation result check

Author: catcherwong

src/EasyCaching.Memcached/DefaultMemcachedCachingProvider.Async.cs

@@ -78,7 +78,8 @@ public override async Task<CacheValue<T>> BaseGetAsync<T>(string cacheKey)
             else
             {
                 OnCacheMiss(cacheKey);
-                throw new EasyCachingException($"opereation fail {result.Message}", result.Exception);
+                CheckResult(result);
+                return CacheValue<T>.NoValue;
             }
         }
 
@@ -133,7 +134,7 @@ public override async Task BaseRemoveAsync(string cacheKey)
             ArgumentCheck.NotNullOrWhiteSpace(cacheKey, nameof(cacheKey));
 
             var data = await _memcachedClient.ExecuteRemoveAsync(this.HandleCacheKey(cacheKey));
-            if(!data.Success) throw new EasyCachingException($"opereation fail {data.Message}", data.Exception);
+            CheckResult(data);
         }
 
         /// <summary>

src/EasyCaching.Memcached/DefaultMemcachedCachingProvider.cs

@@ -2,7 +2,7 @@
 {
     using EasyCaching.Core;
     using EasyCaching.Core.DistributedLock;
-using EasyCaching.Memcached.DistributedLock;
+    using EasyCaching.Memcached.DistributedLock;
     using Microsoft.Extensions.Logging;
     using System;
     using System.Collections.Generic;
@@ -157,9 +157,9 @@ public override CacheValue<T> BaseGet<T>(string cacheKey)
         {
             ArgumentCheck.NotNullOrWhiteSpace(cacheKey, nameof(cacheKey));
 
-            var data = _memcachedClient.PerformGet<T>(this.HandleCacheKey(cacheKey));
+            var data = _memcachedClient.PerformGet<object>(this.HandleCacheKey(cacheKey));
 
-            if (!data.Success) throw new EasyCachingException($"opereation fail {data.Message}", data.Exception);
+            CheckResult(data);
 
             var result = ConvertFromStoredValue<T>(data.Value);
 
@@ -186,7 +186,7 @@ public override void BaseRemove(string cacheKey)
 
             var data = _memcachedClient.ExecuteRemove(this.HandleCacheKey(cacheKey));
 
-            if (!data.Success) throw new EasyCachingException($"opereation fail {data.Message}", data.Exception);
+            CheckResult(data);
         }
 
         /// <summary>
@@ -215,7 +215,7 @@ public override void BaseSet<T>(string cacheKey, T cacheValue, TimeSpan expirati
                 this.ConvertToStoredValue(cacheValue),
                 expiration);
 
-            if (!data.Success) throw new EasyCachingException($"opereation fail {data.Message}", data.Exception);
+            CheckResult(data);
         }
 
         /// <summary>
@@ -261,7 +261,7 @@ public override void BaseRemoveByPrefix(string prefix)
                newValue,
                new TimeSpan(0, 0, 0));
 
-            if (!data.Success) throw new EasyCachingException($"opereation fail {data.Message}", data.Exception);
+            CheckResult(data);
         }
 
         /// <summary>
@@ -442,5 +442,13 @@ private void OnCacheMiss(string cacheKey)
             if (_options.EnableLogging)
                 _logger?.LogInformation($"Cache Missed : cachekey = {cacheKey}");
         }
+
+        private void CheckResult(Enyim.Caching.Memcached.Results.IOperationResult data)
+        {
+            if (!data.Success 
+                && (!data.InnerResult?.Success ?? false) 
+                && (data.InnerResult?.Message?.Contains("Failed to create socket") ?? false))
+                throw new EasyCachingException($"opereation fail, {data.InnerResult?.Message ?? ""}", data.Exception);
+        }
     }
 }

test/EasyCaching.UnitTests/CachingTests/MemcachedProviderTest.cs

@@ -390,7 +390,7 @@ public void Provider_Information_Should_Be_Correct()
     public class MemcachedProviderNoConnectionTest 
     {
         [Fact]
-        public void NoConnectionTest()
+        public async void NoConnectionTest()
         {
             IServiceCollection services = new ServiceCollection();
             services.AddLogging();
@@ -419,6 +419,9 @@ public void NoConnectionTest()
             var provider = factory.GetCachingProvider(EasyCachingConstValue.DefaultMemcachedName);
 
             Assert.Throws<EasyCachingException>(() => provider.Get<string>("123123"));
+            await Assert.ThrowsAnyAsync<EasyCachingException>(() => provider.GetAsync<string>("123123"));
+            Assert.Throws<EasyCachingException>(() => provider.Remove("123123"));
+            await Assert.ThrowsAnyAsync<EasyCachingException>(() => provider.RemoveAsync("123123"));
         }        
     }
 }