Skip to content

Commit 7fd69b7

Browse files
authored
Merge pull request #491 from Memoyu/fix-warning
Fix some CI warning
2 parents a39a5bf + c34e22e commit 7fd69b7

File tree

6 files changed

+5
-46
lines changed

6 files changed

+5
-46
lines changed

bus/EasyCaching.Bus.RabbitMQStream/DefaultRabbitMQStreamBus.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,7 @@ public class DefaultRabbitMQStreamBus : EasyCachingAbstractBus
6262
/// <param name="objectPolicy">Object policy.</param>
6363
/// <param name="rabbitMQOptions">RabbitMQ Options.</param>
6464
/// <param name="serializer">Serializer.</param>
65+
/// <param name="logger">Logger.</param>
6566
public DefaultRabbitMQStreamBus(
6667
IPooledObjectPolicy<IModel> objectPolicy
6768
, IOptions<RabbitMQBusOptions> rabbitMQOptions

sample/EasyCaching.Demo.Locks/Controllers/LocksController.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ public async Task DistributedLockingOperation(int millisecondsTimeout)
3030
catch (Exception ex)
3131
{
3232
// log error
33-
throw;
33+
throw new Exception("Exception", ex);
3434
}
3535
finally
3636
{
@@ -59,7 +59,7 @@ public async Task MemoryLockingOperation(int millisecondsTimeout)
5959
catch (Exception ex)
6060
{
6161
// log error
62-
throw;
62+
throw new Exception("Exception", ex);
6363
}
6464
finally
6565
{

src/EasyCaching.LiteDB/EasyCaching.LiteDB.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
</ItemGroup>
3636
<ItemGroup>
3737
<PackageReference Include="LiteDB" Version="5.0.13" />
38-
<PackageReference Include="Newtonsoft.Json" Version="12.0.3" />
38+
<PackageReference Include="Newtonsoft.Json" Version="13.0.1" />
3939
<PackageReference Include="Microsoft.CSharp" Version="4.7.0" />
4040
</ItemGroup>
4141
</Project>

test/EasyCaching.UnitTests/CachingTests/FasterKvCachingProviderTest.cs

Lines changed: 0 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -76,17 +76,6 @@ protected override void Get_Parallel_Should_Succeed()
7676
{
7777
}
7878

79-
public override Task GetAllByPrefix_Async_Should_Throw_ArgumentNullException_When_Prefix_IsNullOrWhiteSpace(
80-
string preifx)
81-
{
82-
return Task.CompletedTask;
83-
}
84-
85-
public override void GetAllByPrefix_Should_Throw_ArgumentNullException_When_CacheKey_IsNullOrWhiteSpace(
86-
string prefix)
87-
{
88-
}
89-
9079
protected override Task Get_Count_Async_With_Prefix_Should_Succeed()
9180
{
9281
return Task.CompletedTask;
@@ -132,31 +121,10 @@ protected override void GetExpiration_Should_Succeed()
132121
{
133122
}
134123

135-
public override void RemoveByPattern_Should_Succeed()
136-
{
137-
}
138-
139-
public override Task RemoveByPatternAsync_Should_Succeed()
140-
{
141-
return Task.CompletedTask;
142-
}
143-
144-
public override Task RemoveByPrefix_Async_Should_Throw_ArgumentNullException_When_Prefix_IsNullOrWhiteSpace(
145-
string preifx)
146-
147-
{
148-
return Task.CompletedTask;
149-
}
150-
151124
protected override void RemoveByPrefix_Should_Succeed()
152125
{
153126
}
154127

155-
public override void RemoveByPrefix_Should_Throw_ArgumentNullException_When_CacheKey_IsNullOrWhiteSpace(
156-
string prefix)
157-
{
158-
}
159-
160128
protected override Task RemoveByPrefixAsync_Should_Succeed()
161129
{
162130
return Task.CompletedTask;

test/EasyCaching.UnitTests/CachingTests/MemcachedProviderTest.cs

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -115,17 +115,6 @@ protected override void GetByPrefix_Should_Succeed()
115115
{
116116
}
117117

118-
[Fact]
119-
public override void RemoveByPattern_Should_Succeed()
120-
{
121-
}
122-
123-
[Fact]
124-
public override async Task RemoveByPatternAsync_Should_Succeed()
125-
{
126-
await Task.FromResult(1);
127-
}
128-
129118
[Fact]
130119
protected override async Task GetByPrefixAsync_Should_Succeed()
131120
{

test/EasyCaching.UnitTests/SerializerTests/MemoryPackSerializerTest.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ public MemoryPackSerializerTest()
1414
}
1515

1616
//This should be overrided becuse it is not supported by memory-pack
17+
[Fact]
1718
public override void DeserializeObject_should_Succeed()
1819
{
1920
Person input = new("test", "test1");

0 commit comments

Comments
 (0)