replace ineffective array type-checking with simple arrayref pinning

Author: h3xds1nz

src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/Media/Imaging/BitmapSource.cs

@@ -24,7 +24,8 @@
 using System.IO.Packaging;
 using UnsafeNativeMethods = MS.Win32.PresentationCore.UnsafeNativeMethods;
 using SR = MS.Internal.PresentationCore.SR;
-using MS.Internal.PresentationCore;                        // SecurityHelper
+using MS.Internal.PresentationCore;
+using System.Runtime.CompilerServices;
 
 namespace System.Windows.Media.Imaging
 {
@@ -657,7 +658,7 @@ unsafe internal void CriticalCopyPixels(Int32Rect sourceRect, Array pixels, int
             ArgumentNullException.ThrowIfNull(pixels);
 
             if (pixels.Rank != 1)
-                throw new ArgumentException(SR.Collection_BadRank, "pixels");
+                throw new ArgumentException(SR.Collection_BadRank, nameof(pixels));
 
             if (offset < 0)
             {
@@ -680,43 +681,13 @@ unsafe internal void CriticalCopyPixels(Int32Rect sourceRect, Array pixels, int
 
             int destBufferSize = checked(elementSize * (pixels.Length - offset));
 
+            // Check whether offset is out of bounds manually
+            if (offset >= pixels.Length)
+                throw new IndexOutOfRangeException();
 
-            if (pixels is byte[])
-            {
-                fixed (void* pixelArray = &((byte[])pixels)[offset])
-                    CriticalCopyPixels(sourceRect, (IntPtr)pixelArray, destBufferSize, stride);
-            }
-            else if (pixels is short[])
-            {
-                fixed (void* pixelArray = &((short[])pixels)[offset])
-                    CriticalCopyPixels(sourceRect, (IntPtr)pixelArray, destBufferSize, stride);
-            }
-            else if (pixels is ushort[])
-            {
-                fixed (void* pixelArray = &((ushort[])pixels)[offset])
-                    CriticalCopyPixels(sourceRect, (IntPtr)pixelArray, destBufferSize, stride);
-            }
-            else if (pixels is int[])
-            {
-                fixed (void* pixelArray = &((int[])pixels)[offset])
-                    CriticalCopyPixels(sourceRect, (IntPtr)pixelArray, destBufferSize, stride);
-            }
-            else if (pixels is uint[])
-            {
-                fixed (void* pixelArray = &((uint[])pixels)[offset])
-                    CriticalCopyPixels(sourceRect, (IntPtr)pixelArray, destBufferSize, stride);
-            }
-            else if (pixels is float[])
-            {
-                fixed (void* pixelArray = &((float[])pixels)[offset])
-                    CriticalCopyPixels(sourceRect, (IntPtr)pixelArray, destBufferSize, stride);
-            }
-            else if (pixels is double[])
-            {
-                fixed (void* pixelArray = &((double[])pixels)[offset])
-                    CriticalCopyPixels(sourceRect, (IntPtr)pixelArray, destBufferSize, stride);
-            }
-}
+            fixed (byte* pixelArray = &Unsafe.AddByteOffset(ref MemoryMarshal.GetArrayDataReference(pixels), (nint)offset * elementSize))
+                CriticalCopyPixels(sourceRect, (nint)pixelArray, destBufferSize, stride);
+        }
 
         /// <summary>
         /// CriticalCopyPixels
@@ -728,7 +699,7 @@ unsafe internal void CriticalCopyPixels(Int32Rect sourceRect, Array pixels, int
         internal void CriticalCopyPixels(Int32Rect sourceRect, IntPtr buffer, int bufferSize, int stride)
         {
             if (buffer == IntPtr.Zero)
-                throw new ArgumentNullException("buffer");
+                throw new ArgumentNullException(nameof(buffer));
 
             ArgumentOutOfRangeException.ThrowIfNegativeOrZero(stride);