-
Notifications
You must be signed in to change notification settings - Fork 136
Remove obsolete arcade-services submodule and upgrade to netcoreapp3.0 version of Darc. #1368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +0,0 @@ | ||
[submodule "tools-local/arcade-services"] | ||
path = tools-local/arcade-services | ||
url = https://github.com/dotnet/arcade-services | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
1.1.0-beta.19515.3 | ||
1.1.0-beta.19568.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -80,7 +80,7 @@ fi | |
echo "Found bootstrap SDK $SDK_VERSION" | ||
CLI_PATH="$SCRIPT_ROOT/.dotnet" | ||
DarcVersion=$(cat $SCRIPT_ROOT/DarcVersion.txt) | ||
DARC_DLL="$CLI_PATH/tools/.store/microsoft.dotnet.darc/$DarcVersion/microsoft.dotnet.darc/$DarcVersion/tools/netcoreapp2.1/any/Microsoft.DotNet.Darc.dll" | ||
DARC_DLL="$CLI_PATH/tools/.store/microsoft.dotnet.darc/$DarcVersion/microsoft.dotnet.darc/$DarcVersion/tools/netcoreapp3.0/any/Microsoft.DotNet.Darc.dll" | ||
|
||
if [ $SKIP_BUILD -ne 1 ]; then | ||
|
||
|
@@ -148,15 +148,11 @@ git submodule foreach --quiet --recursive ' | |
# Now re-uberclone into the tarball src directory. Since we reuse the .gitdirs, this shouldn't hit the network at all. | ||
ignored_repos="https://dev.azure.com/dnceng/internal/_git/dotnet-optimization;https://dev.azure.com/devdiv/DevDiv/_git/DotNet-Trusted;https://devdiv.visualstudio.com/DevDiv/_git/DotNet-Trusted;https://[email protected]/dnceng/internal/_git/dotnet-optimization;https://dev.azure.com/dnceng/internal/_git/dotnet-core-setup;https://github.com/dotnet/source-build-reference-packages" | ||
|
||
#export the LC_LIB_PATH for libgit2 so file as fedora fails to find it in the repodir | ||
export LD_LIBRARY_PATH=$CLI_PATH/tools/.store/microsoft.dotnet.darc/$DarcVersion/microsoft.dotnet.darc/$DarcVersion/tools/netcoreapp2.1/any/runtimes/rhel-x64/native/ | ||
|
||
"$CLI_PATH/dotnet" "$DARC_DLL" clone --repos-folder=$TARBALL_ROOT/src/ --git-dir-folder $SCRIPT_ROOT/.git/modules/src/ --include-toolset --ignore-repos "$ignored_repos" --azdev-pat bogus --github-pat bogus --depth 0 --debug | ||
|
||
# now we don't need .git/modules/src or Darc anymore | ||
if [ $MINIMIZE_DISK_USAGE -eq 1 ]; then | ||
rm -rf "$SCRIPT_ROOT/.git/modules/src" | ||
rm -rf $SCRIPT_ROOT/tools-local/arcade-services | ||
fi | ||
|
||
# then delete the master copies - we only need the specific hashes | ||
|
@@ -197,10 +193,7 @@ cp -r $SCRIPT_ROOT/patches $TARBALL_ROOT/ | |
cp -r $SCRIPT_ROOT/scripts $TARBALL_ROOT/ | ||
cp -r $SCRIPT_ROOT/repos $TARBALL_ROOT/ | ||
cp -r $SCRIPT_ROOT/tools-local $TARBALL_ROOT/ | ||
rm -rf $TARBALL_ROOT/tools-local/arcade-services/ | ||
rm -rf $TARBALL_ROOT/.dotnet/shared/2.1.0/ | ||
rm -rf $TARBALL_ROOT/.dotnet/tools/ | ||
rm -rf $TARBALL_ROOT/.dotnet/host/fxr/2.1.0/ | ||
cp -r $SCRIPT_ROOT/bin/git-info $TARBALL_ROOT/ | ||
|
||
cp $SCRIPT_ROOT/support/tarball/build.sh $TARBALL_ROOT/build.sh | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule arcade-services
deleted from
e9a0a5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.