Skip to content

Add MS.DotNet.Common.ProjectTemplates.2.1,1.0.2-beta3 #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 11, 2021
Merged

Add MS.DotNet.Common.ProjectTemplates.2.1,1.0.2-beta3 #291

merged 2 commits into from
Nov 11, 2021

Conversation

dseefeld
Copy link
Contributor

@dseefeld dseefeld commented Oct 25, 2021 •
edited
Loading

@dseefeld dseefeld added the no-merge Do not merge label Oct 25, 2021
@dseefeld dseefeld removed the no-merge Do not merge label Nov 3, 2021
@dseefeld dseefeld enabled auto-merge (squash) November 3, 2021 16:53
MichaelSimons
MichaelSimons reviewed Nov 8, 2021
View reviewed changes
Copy link
Member

@MichaelSimons MichaelSimons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come this single 2.1 Common.ProjectTemplates package is added to SBRP but not the other 2.1 ProjectTemplates or the other out of support versions of ProjectTemplates are not? I am trying to understand the rules/policies we should be using. IMO if would be nice to eliminate the text only packages in installer. They should either be moved to SBRP or the source repos should be added to source-build.

@dseefeld
Copy link
Contributor Author

How come this single 2.1 Common.ProjectTemplates package is added to SBRP but not the other 2.1 ProjectTemplates or the other out of support versions of ProjectTemplates are not? I am trying to understand the rules/policies we should be using. IMO if would be nice to eliminate the text only packages in installer. They should either be moved to SBRP or the source repos should be added to source-build.

The difference is that this package is older and doesn't have an updated license. Since the version number is not dynamic and the license needs to be updated, I added it to SBRP.

@dseefeld dseefeld merged commit 897a970 into dotnet:main Nov 11, 2021
MichaelSimons pushed a commit to MichaelSimons/source-build-reference-packages that referenced this pull request Jan 27, 2022
@dseefeld @MichaelSimons
Add MS.DotNet.Common.ProjectTemplates.2.1,1.0.2-beta3 (dotnet#291)
9e951a8
MichaelSimons added a commit that referenced this pull request Jan 27, 2022
@MichaelSimons @dseefeld
Add MS.DotNet.Common.ProjectTemplates.2.1,1.0.2-beta3 (#291) (#323)
71a327c 
Co-authored-by: Dan Seefeldt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelSimons MichaelSimons MichaelSimons approved these changes

@crummel crummel Awaiting requested review from crummel

@lbussell lbussell Awaiting requested review from lbussell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

.NET EULA license in some text-only packages
2 participants
@dseefeld @MichaelSimons