Skip to content

[release/9.0] Update dependencies from dotnet/arcade #1253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: release/9.0
Choose a base branch
from
Open

[release/9.0] Update dependencies from dotnet/arcade #1253

wants to merge 3 commits into from

Conversation

dotnet-maestro[bot]
Copy link
Contributor

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Updates to .NET SDKs:
    • Updates tools.dotnet to 9.0.106

@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20250…
52c983d 
…513.5

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk
 From Version 9.0.0-beta.25208.6 -> To Version 9.0.0-beta.25263.5
@dotnet-maestro dotnet-maestro bot requested a review from a team as a code owner May 14, 2025 21:16
@ellahathaway
Copy link
Member

Build errors:

error : System.Formats.Asn1 8.0.1 doesn't support net5.0 and has not been tested with it.

This error occurs due to the changes introduced in dotnet/source-build-reference-packages#1216, which added NuGet.Package.6.12.1, NuGet.Protocol.6.12.1, and NuGet.Credentials.6.12.1. These NuGet packages target .NET 5.0 and have System.Formats.Asn1.8.0.1 as a transitive dependency. However, System.Formats.Asn1.8.0.1 does not include .NET 5.0 as a supported target framework, which leads to this build error.

I'm not sure why this wasn't caught by PR checks. @MichaelSimons, any ideas?

@ellahathaway
Copy link
Member

Also the fix for these failures is going to have to be done in multiple parts.

  1. Fix the packages in this PR or in a separate PR
  2. Either push a commit to this PR for suppressing the warning or wait to merge this PR until the next release
  3. Revert suppressing the warning if we decided to enable it

@MichaelSimons
Copy link
Member

I see two options which aren't mutually exclusive.

  1. Add true to the affected projects.
  2. Investigate if net5.0 support in the affected projects is necessary. If not required, we can remove net5.0 support from these packages.

I think we must do #1 now to unblock this PR and potential build issues in full source-build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ellahathaway @MichaelSimons