-
Notifications
You must be signed in to change notification settings - Fork 40
Update IdentityModel to 7.4.1 #293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@mthalman @MichaelSimons PTAL (For some reason I can't request reviews in the PR) |
Not sure how to investigate this error, did I do something wrong?
|
There are two patches applied to the repo, looks like at least one of them needs updating - https://github.com/dotnet/source-build-externals/tree/main/patches/azure-activedirectory-identitymodel-extensions-for-dotnet. You can test this locally by running the local source-build - |
I forgot to mention this guidance - https://github.com/dotnet/source-build-externals?tab=readme-ov-file#updating-an-external-component-to-a-newer-version |
@eerhardt @MichaelSimons where can I find info on how to fix the patch files? It's not obvious to me how those get created or what they correspond to. My local build failed in the same way as CI |
The patching guidelines documentation described the process pretty well. When a patch fails, I begin by investigating the content of the patch. If the content is no longer applicable (i.e. the new version implemented the patched code), I'll delete the patch. Otherwise, make the patched changes to the new version, create the new patch, and delete the old patch. |
I just opened a PR to include steps to manually apply patches and the cmd for easily creating/updating patches. #301. Please provide feedback. |
@MichaelSimons I ran |
Did you make any changes? They have to be committed. |
This reverts commit ad81a26.
Looks like they removed |
It can be verified in this PR build. I peeked at the generated assembly from this build and it has the correct assembly version set. Should be good to go. |
@mthalman @MichaelSimons I don't have permissions to merge here, could one of you click the button? |
For dotnet/aspnetcore#54601