Fix dotnet store for netcoreapp3.0 #3345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix msbuild batching error that caused O(N^2) redundant work, and flakiness due to race conditions between the redundant workers.
rainersigwald
approved these changes
Jun 20, 2019
The issue for 3.0 was basically that dotnet store does a kind of custom self-contained deployment of .net core runtime + crossgen.exe as a first step. The framework reference work broke the way it was doing it by reading nuget assets. I had to copy some of the logic for 3.0 SCD, starting here: https://github.com/dotnet/sdk/pull/3345/files#diff-272dc14b0ed4e9d846b62bb698af2f42R289 The code in these targets is pretty rough. I have a plan where I would rip this all out and just use crossgen directly without this step, as PublishReadyToRun does, but I'm not sure when I'll be able to land that change yet. |
|
Got it, thanks. |
This was referenced Jul 23, 2019
dsplaisted
pushed a commit
to dsplaisted/sdk
that referenced
this pull request
Feb 19, 2020
…029.1 (dotnet#3345) - Microsoft.NET.Sdk.Web - 3.1.100-preview2.19529.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix msbuild batching error that caused O(N^2) redundant work, and flakiness due to race conditions between the redundant workers.
And replace ContinueOnError=WarnAndContinue with just ignoring standard error format on exec of crossgen. crossgen prior to 3.0 is notorious for spewing noise and the only thing that is reliable is the exit code. The previous approach around it was way too big of a hammer.
This is the "minimal fix" for 3.0. I am still working on a major re-design and simplification of dotnet store, but that will not likely be ready for 3.0 preview 7 and we want to have these issues fixed before then.
It is also not clear yet if we would be able to use the simplified design for all TFMs or only on netcoreapp3.0. That is because the crux of the re-design is to use the new PublishReadyToRun code as the foundation.