Skip to content

[WIP NO MERGE]: Add support for RuntimeFrameworkName to set the platform package for .NET Core 2.1 projects #2394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

[WIP NO MERGE]: Add support for RuntimeFrameworkName to set the platform package for .NET Core 2.1 projects #2394

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6dc87d4
Add support for setting RuntimeFrameworkName
Jul 10, 2018
50dd08b
Add support for ASP.NET Core shared framework names, and issue an err…
Jul 12, 2018
9f7fc3b
Set the default version for ASP.NET Core to 2.1.3
Jul 12, 2018
9daf724
Update generated xlf files
Jul 12, 2018
71028be
Move DefaultImplicitPackages back to Microsoft.NET.Sdk.Common.targets…
Jul 13, 2018
15ce2ad
PR feedback - remove reduntant metadata setter and revert change to D…
Jul 13, 2018
4306bdd
Add a warning when there is an explicit PackageRef to AspNetCore.App/…
Jul 14, 2018
b9dafac
Condense the most important info in NETSDK1071 to one line
Jul 14, 2018
faa4e2c
Remove code snippet from NETSDK1071 and only issue NETSDK1071 for .NE…
Jul 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/Tasks/Common/Resources/Strings.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,4 +397,16 @@ The following are names of parameters or literal values and should not be transl
<value>NETSDK1069: This project uses a library that targets .NET Standard 1.5 or higher, and the project targets a version of .NET Framework that doesn't have built-in support for that version of .NET Standard. Visit https://aka.ms/net-standard-known-issues for a set of known issues. Consider retargeting to .NET Framework 4.7.2.</value>
<comment>{StrBegin="NETSDK1069: "}</comment>
</data>
<data name="UnrecognizedRuntimeFrameworkName" xml:space="preserve">
<value>NETSDK1070: This project uses an unsupported value for RuntimeFrameworkName. Currently, only valid values are: Microsoft.NETCore.App, Microsoft.AspNetCore.App, or Microsoft.AspNetCore.All.</value>
<comment>{StrBegin="NETSDK1070: "}</comment>
</data>
<data name="AspNetCoreRequiresRuntimeFrameworkName" xml:space="preserve">
<value>NETSDK1071: A PackageReference for '{0}' was included in your project. This will cause issues when upgrading to 2.1.3 and higher. To upgrade, remove this PackageReference and add the RuntimeFrameworkName property to {1}. For more information, see {2}.</value>
<comment>{StrBegin="NETSDK1071: "}
{0} - Package Id (AspNetCore.App or .All)
{1} - Project name
{2} - More info link
</comment>
</data>
</root>
14 changes: 14 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.cs.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,15 @@
<xliff xmlns="urn:oasis:names:tc:xliff:document:1.2" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" version="1.2" xsi:schemaLocation="urn:oasis:names:tc:xliff:document:1.2 xliff-core-1.2-transitional.xsd">
<file datatype="xml" source-language="en" target-language="cs" original="../Strings.resx">
<body>
<trans-unit id="AspNetCoreRequiresRuntimeFrameworkName">
<source>NETSDK1071: A PackageReference for '{0}' was included in your project. This will cause issues when upgrading to 2.1.3 and higher. To upgrade, remove this PackageReference and add the RuntimeFrameworkName property to {1}. For more information, see {2}.</source>
<target state="new">NETSDK1071: A PackageReference for '{0}' was included in your project. This will cause issues when upgrading to 2.1.3 and higher. To upgrade, remove this PackageReference and add the RuntimeFrameworkName property to {1}. For more information, see {2}.</target>
<note>{StrBegin="NETSDK1071: "}
{0} - Package Id (AspNetCore.App or .All)
{1} - Project name
{2} - More info link
</note>
</trans-unit>
<trans-unit id="AtLeastOneTargetFrameworkMustBeSpecified">
<source>NETSDK1001: At least one possible target framework must be specified.</source>
<target state="needs-review-translation">Je potřeba zadat alespoň jednu možnou cílovou platformu</target>
Expand Down Expand Up @@ -112,6 +121,11 @@
<target state="needs-review-translation">Neplatný řetězec verze NuGet: {0}</target>
<note>{StrBegin="NETSDK1018: "}</note>
</trans-unit>
<trans-unit id="UnrecognizedRuntimeFrameworkName">
<source>NETSDK1070: This project uses an unsupported value for RuntimeFrameworkName. Currently, only valid values are: Microsoft.NETCore.App, Microsoft.AspNetCore.App, or Microsoft.AspNetCore.All.</source>
<target state="new">NETSDK1070: This project uses an unsupported value for RuntimeFrameworkName. Currently, only valid values are: Microsoft.NETCore.App, Microsoft.AspNetCore.App, or Microsoft.AspNetCore.All.</target>
<note>{StrBegin="NETSDK1070: "}</note>
</trans-unit>
<trans-unit id="UnsupportedFramework">
<source>NETSDK1019: {0} is an unsupported framework.</source>
<target state="needs-review-translation">{0} není podporovaná platforma.</target>
Expand Down
14 changes: 14 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.de.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,15 @@
<xliff xmlns="urn:oasis:names:tc:xliff:document:1.2" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" version="1.2" xsi:schemaLocation="urn:oasis:names:tc:xliff:document:1.2 xliff-core-1.2-transitional.xsd">
<file datatype="xml" source-language="en" target-language="de" original="../Strings.resx">
<body>
<trans-unit id="AspNetCoreRequiresRuntimeFrameworkName">
<source>NETSDK1071: A PackageReference for '{0}' was included in your project. This will cause issues when upgrading to 2.1.3 and higher. To upgrade, remove this PackageReference and add the RuntimeFrameworkName property to {1}. For more information, see {2}.</source>
<target state="new">NETSDK1071: A PackageReference for '{0}' was included in your project. This will cause issues when upgrading to 2.1.3 and higher. To upgrade, remove this PackageReference and add the RuntimeFrameworkName property to {1}. For more information, see {2}.</target>
<note>{StrBegin="NETSDK1071: "}
{0} - Package Id (AspNetCore.App or .All)
{1} - Project name
{2} - More info link
</note>
</trans-unit>
<trans-unit id="AtLeastOneTargetFrameworkMustBeSpecified">
<source>NETSDK1001: At least one possible target framework must be specified.</source>
<target state="needs-review-translation">Geben Sie mindestens ein mögliches Zielframework an.</target>
Expand Down Expand Up @@ -112,6 +121,11 @@
<target state="needs-review-translation">Ungültige NuGet-Versionszeichenfolge: {0}.</target>
<note>{StrBegin="NETSDK1018: "}</note>
</trans-unit>
<trans-unit id="UnrecognizedRuntimeFrameworkName">
<source>NETSDK1070: This project uses an unsupported value for RuntimeFrameworkName. Currently, only valid values are: Microsoft.NETCore.App, Microsoft.AspNetCore.App, or Microsoft.AspNetCore.All.</source>
<target state="new">NETSDK1070: This project uses an unsupported value for RuntimeFrameworkName. Currently, only valid values are: Microsoft.NETCore.App, Microsoft.AspNetCore.App, or Microsoft.AspNetCore.All.</target>
<note>{StrBegin="NETSDK1070: "}</note>
</trans-unit>
<trans-unit id="UnsupportedFramework">
<source>NETSDK1019: {0} is an unsupported framework.</source>
<target state="needs-review-translation">{0} ist ein nicht unterstütztes Framework.</target>
Expand Down
14 changes: 14 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.es.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,15 @@
<xliff xmlns="urn:oasis:names:tc:xliff:document:1.2" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" version="1.2" xsi:schemaLocation="urn:oasis:names:tc:xliff:document:1.2 xliff-core-1.2-transitional.xsd">
<file datatype="xml" source-language="en" target-language="es" original="../Strings.resx">
<body>
<trans-unit id="AspNetCoreRequiresRuntimeFrameworkName">
<source>NETSDK1071: A PackageReference for '{0}' was included in your project. This will cause issues when upgrading to 2.1.3 and higher. To upgrade, remove this PackageReference and add the RuntimeFrameworkName property to {1}. For more information, see {2}.</source>
<target state="new">NETSDK1071: A PackageReference for '{0}' was included in your project. This will cause issues when upgrading to 2.1.3 and higher. To upgrade, remove this PackageReference and add the RuntimeFrameworkName property to {1}. For more information, see {2}.</target>
<note>{StrBegin="NETSDK1071: "}
{0} - Package Id (AspNetCore.App or .All)
{1} - Project name
{2} - More info link
</note>
</trans-unit>
<trans-unit id="AtLeastOneTargetFrameworkMustBeSpecified">
<source>NETSDK1001: At least one possible target framework must be specified.</source>
<target state="needs-review-translation">Debe especificarse al menos una plataforma de destino posible.</target>
Expand Down Expand Up @@ -112,6 +121,11 @@
<target state="needs-review-translation">Cadena de versión de NuGet no válida: "{0}".</target>
<note>{StrBegin="NETSDK1018: "}</note>
</trans-unit>
<trans-unit id="UnrecognizedRuntimeFrameworkName">
<source>NETSDK1070: This project uses an unsupported value for RuntimeFrameworkName. Currently, only valid values are: Microsoft.NETCore.App, Microsoft.AspNetCore.App, or Microsoft.AspNetCore.All.</source>
<target state="new">NETSDK1070: This project uses an unsupported value for RuntimeFrameworkName. Currently, only valid values are: Microsoft.NETCore.App, Microsoft.AspNetCore.App, or Microsoft.AspNetCore.All.</target>
<note>{StrBegin="NETSDK1070: "}</note>
</trans-unit>
<trans-unit id="UnsupportedFramework">
<source>NETSDK1019: {0} is an unsupported framework.</source>
<target state="needs-review-translation">{0} es una plataforma no compatible.</target>
Expand Down
14 changes: 14 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.fr.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,15 @@
<xliff xmlns="urn:oasis:names:tc:xliff:document:1.2" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" version="1.2" xsi:schemaLocation="urn:oasis:names:tc:xliff:document:1.2 xliff-core-1.2-transitional.xsd">
<file datatype="xml" source-language="en" target-language="fr" original="../Strings.resx">
<body>
<trans-unit id="AspNetCoreRequiresRuntimeFrameworkName">
<source>NETSDK1071: A PackageReference for '{0}' was included in your project. This will cause issues when upgrading to 2.1.3 and higher. To upgrade, remove this PackageReference and add the RuntimeFrameworkName property to {1}. For more information, see {2}.</source>
<target state="new">NETSDK1071: A PackageReference for '{0}' was included in your project. This will cause issues when upgrading to 2.1.3 and higher. To upgrade, remove this PackageReference and add the RuntimeFrameworkName property to {1}. For more information, see {2}.</target>
<note>{StrBegin="NETSDK1071: "}
{0} - Package Id (AspNetCore.App or .All)
{1} - Project name
{2} - More info link
</note>
</trans-unit>
<trans-unit id="AtLeastOneTargetFrameworkMustBeSpecified">
<source>NETSDK1001: At least one possible target framework must be specified.</source>
<target state="needs-review-translation">Au moins un framework cible doit être spécifié.</target>
Expand Down Expand Up @@ -112,6 +121,11 @@
<target state="needs-review-translation">Chaîne de version NuGet non valide : '{0}'.</target>
<note>{StrBegin="NETSDK1018: "}</note>
</trans-unit>
<trans-unit id="UnrecognizedRuntimeFrameworkName">
<source>NETSDK1070: This project uses an unsupported value for RuntimeFrameworkName. Currently, only valid values are: Microsoft.NETCore.App, Microsoft.AspNetCore.App, or Microsoft.AspNetCore.All.</source>
<target state="new">NETSDK1070: This project uses an unsupported value for RuntimeFrameworkName. Currently, only valid values are: Microsoft.NETCore.App, Microsoft.AspNetCore.App, or Microsoft.AspNetCore.All.</target>
<note>{StrBegin="NETSDK1070: "}</note>
</trans-unit>
<trans-unit id="UnsupportedFramework">
<source>NETSDK1019: {0} is an unsupported framework.</source>
<target state="needs-review-translation">{0} est un framework non pris en charge.</target>
Expand Down
14 changes: 14 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.it.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,15 @@
<xliff xmlns="urn:oasis:names:tc:xliff:document:1.2" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" version="1.2" xsi:schemaLocation="urn:oasis:names:tc:xliff:document:1.2 xliff-core-1.2-transitional.xsd">
<file datatype="xml" source-language="en" target-language="it" original="../Strings.resx">
<body>
<trans-unit id="AspNetCoreRequiresRuntimeFrameworkName">
<source>NETSDK1071: A PackageReference for '{0}' was included in your project. This will cause issues when upgrading to 2.1.3 and higher. To upgrade, remove this PackageReference and add the RuntimeFrameworkName property to {1}. For more information, see {2}.</source>
<target state="new">NETSDK1071: A PackageReference for '{0}' was included in your project. This will cause issues when upgrading to 2.1.3 and higher. To upgrade, remove this PackageReference and add the RuntimeFrameworkName property to {1}. For more information, see {2}.</target>
<note>{StrBegin="NETSDK1071: "}
{0} - Package Id (AspNetCore.App or .All)
{1} - Project name
{2} - More info link
</note>
</trans-unit>
<trans-unit id="AtLeastOneTargetFrameworkMustBeSpecified">
<source>NETSDK1001: At least one possible target framework must be specified.</source>
<target state="needs-review-translation">È necessario specificare almeno un framework di destinazione possibile.</target>
Expand Down Expand Up @@ -112,6 +121,11 @@
<target state="needs-review-translation">La stringa di versione '{0}' di NuGet non è valida.</target>
<note>{StrBegin="NETSDK1018: "}</note>
</trans-unit>
<trans-unit id="UnrecognizedRuntimeFrameworkName">
<source>NETSDK1070: This project uses an unsupported value for RuntimeFrameworkName. Currently, only valid values are: Microsoft.NETCore.App, Microsoft.AspNetCore.App, or Microsoft.AspNetCore.All.</source>
<target state="new">NETSDK1070: This project uses an unsupported value for RuntimeFrameworkName. Currently, only valid values are: Microsoft.NETCore.App, Microsoft.AspNetCore.App, or Microsoft.AspNetCore.All.</target>
<note>{StrBegin="NETSDK1070: "}</note>
</trans-unit>
<trans-unit id="UnsupportedFramework">
<source>NETSDK1019: {0} is an unsupported framework.</source>
<target state="needs-review-translation">{0} è un framework non supportato.</target>
Expand Down
Loading