Skip to content

Commit ecefb5e

Browse files
github-actions[bot]noahfalkjeffschwMSFT
authored
Initialize m_fInPlaceSS (#109013)
A recent fix added a new field to the DebuggerPatchSkip object and missed initializing it false. This causes the new in-place patch skipping logic activate at random depending on the value of uninitialized memory. Fixing this by initializing the variable. Co-authored-by: Noah Falk <[email protected]> Co-authored-by: Jeff Schwartz <[email protected]>
1 parent 83d152c commit ecefb5e

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

src/coreclr/debug/ee/controller.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4334,6 +4334,9 @@ DebuggerPatchSkip::DebuggerPatchSkip(Thread *thread,
43344334
DebuggerControllerPatch *patch)
43354335
: DebuggerController(thread, AppDomain::GetCurrentDomain()),
43364336
m_address(patch->address)
4337+
#ifdef OUT_OF_PROCESS_SETTHREADCONTEXT
4338+
,m_fInPlaceSS(false)
4339+
#endif
43374340
{
43384341
LOG((LF_CORDB, LL_INFO10000,
43394342
"DPS::DPS: Patch skip 0x%p\n", patch->address));

0 commit comments

Comments
 (0)