Remove redundant nullable warning suppression (#118347)

Author: xtqqczze

src/coreclr/System.Private.CoreLib/src/System/Attribute.CoreCLR.cs

@@ -170,7 +170,7 @@ private static Attribute[] InternalGetCustomAttributes(EventInfo element, Type t
             {
                 rtAdd = rtAdd.GetParentDefinition();
                 if (rtAdd != null)
-                    return rtAdd.DeclaringType!.GetEvent(ev.Name!);
+                    return rtAdd.DeclaringType!.GetEvent(ev.Name);
             }
             return null;
         }

src/coreclr/System.Private.CoreLib/src/System/Diagnostics/StackFrameHelper.cs

@@ -118,7 +118,7 @@ internal void InitializeSourceInfo(bool fNeedFileInfo, Exception? exception)
                     // ENC or the source/line info was already retrieved, the method token is 0.
                     if (rgiMethodToken![index] != 0)
                     {
-                        GetSourceLineInfo(s_stackTraceSymbolsCache!, rgAssembly![index], rgAssemblyPath![index]!, rgLoadedPeAddress![index], rgiLoadedPeSize![index], rgiIsFileLayout![index],
+                        GetSourceLineInfo(s_stackTraceSymbolsCache, rgAssembly![index], rgAssemblyPath![index], rgLoadedPeAddress![index], rgiLoadedPeSize![index], rgiIsFileLayout![index],
                             rgInMemoryPdbAddress![index], rgiInMemoryPdbSize![index], rgiMethodToken![index],
                             rgiILOffset![index], out rgFilename![index], out rgiLineNumber![index], out rgiColumnNumber![index]);
                     }

src/coreclr/System.Private.CoreLib/src/System/GC.CoreCLR.cs

@@ -884,7 +884,7 @@ private static unsafe void ConfigCallback(void* configurationContext, void* name
 
             ref GCConfigurationContext context = ref Unsafe.As<byte, GCConfigurationContext>(ref *(byte*)configurationContext);
             Debug.Assert(context.Configurations != null);
-            Dictionary<string, object> configurationDictionary = context.Configurations!;
+            Dictionary<string, object> configurationDictionary = context.Configurations;
 
             string nameAsString = Marshal.PtrToStringUTF8((IntPtr)name)!;
             switch (type)

src/coreclr/System.Private.CoreLib/src/System/Reflection/Emit/RuntimeModuleBuilder.cs

@@ -416,7 +416,7 @@ private static MethodBase GetGenericMethodBaseDefinition(MethodBase methodBase)
                 {
                     Debug.Assert(masmi != null);
 
-                    methDef = masmi.GetGenericMethodDefinition()!;
+                    methDef = masmi.GetGenericMethodDefinition();
                     methDef = methDef.Module.ResolveMethod(
                         methodBase.MetadataToken,
                         methDef.DeclaringType?.GetGenericArguments(),
@@ -1070,7 +1070,7 @@ internal int GetMethodTokenInternal(MethodBase method, Type[]? optionalParameter
 
                 if (!isGenericMethodDef)
                 {
-                    methodInfoUnbound = methodInfo.GetGenericMethodDefinition()!;
+                    methodInfoUnbound = methodInfo.GetGenericMethodDefinition();
                 }
 
                 if (!Equals(methodInfoUnbound.Module)

src/coreclr/System.Private.CoreLib/src/System/Reflection/RuntimeCustomAttributeData.cs

@@ -253,10 +253,10 @@ private RuntimeCustomAttributeData(RuntimeModule scope, MetadataToken caCtorToke
             m_scope = scope;
             m_ctor = (RuntimeConstructorInfo)RuntimeType.GetMethodBase(m_scope, caCtorToken)!;
 
-            if (m_ctor!.DeclaringType!.IsGenericType)
+            if (m_ctor.DeclaringType!.IsGenericType)
             {
                 MetadataImport metadataScope = m_scope.MetadataImport;
-                Type attributeType = m_scope.ResolveType(metadataScope.GetParentToken(caCtorToken), null, null)!;
+                Type attributeType = m_scope.ResolveType(metadataScope.GetParentToken(caCtorToken), null, null);
                 m_ctor = (RuntimeConstructorInfo)m_scope.ResolveMethod(caCtorToken, attributeType.GenericTypeArguments, null)!.MethodHandle.GetMethodInfo();
             }
 

src/coreclr/System.Private.CoreLib/src/System/Reflection/RuntimePropertyInfo.cs

@@ -305,7 +305,7 @@ internal ReadOnlySpan<ParameterInfo> GetIndexParametersSpan()
                     Array.Empty<ParameterInfo>();
 
                 for (int i = 0; i < propParams.Length; i++)
-                    propParams[i] = new RuntimeParameterInfo((RuntimeParameterInfo)methParams![i], this);
+                    propParams[i] = new RuntimeParameterInfo((RuntimeParameterInfo)methParams[i], this);
 
                 m_parameters = propParams;
             }

src/coreclr/System.Private.CoreLib/src/System/RuntimeHandles.cs

@@ -1048,7 +1048,7 @@ internal bool IsNullHandle()
 
         public IntPtr GetFunctionPointer()
         {
-            IntPtr ptr = GetFunctionPointer(EnsureNonNullMethodInfo(m_value!).Value);
+            IntPtr ptr = GetFunctionPointer(EnsureNonNullMethodInfo(m_value).Value);
             GC.KeepAlive(m_value);
             return ptr;
         }

src/coreclr/System.Private.CoreLib/src/System/RuntimeType.CoreCLR.cs

@@ -560,7 +560,7 @@ private void MergeWithGlobalList(T[] list)
                                 cachedMembers = cachedMembers2;
                             }
 
-                            Debug.Assert(cachedMembers![freeSlotIndex] == null);
+                            Debug.Assert(cachedMembers[freeSlotIndex] == null);
                             Volatile.Write(ref cachedMembers[freeSlotIndex], newMemberInfo); // value may be read outside of lock
                             freeSlotIndex++;
                         }
@@ -1350,7 +1350,7 @@ private void PopulateProperties(
 
                                 for (int j = 0; j < list.Count; j++)
                                 {
-                                    if (propertyInfo.EqualsSig(list[j]!))
+                                    if (propertyInfo.EqualsSig(list[j]))
                                     {
                                         duplicate = true;
                                         break;

src/coreclr/System.Private.CoreLib/src/System/String.CoreCLR.cs

@@ -40,7 +40,7 @@ public static string Intern(string str)
         {
             ArgumentNullException.ThrowIfNull(str);
             Intern(new StringHandleOnStack(ref str!));
-            return str!;
+            return str;
         }
 
         [LibraryImport(RuntimeHelpers.QCall, EntryPoint = "String_IsInterned")]

src/libraries/Common/src/System/IO/PathInternal.cs

@@ -218,7 +218,7 @@ internal static bool RemoveRelativeSegments(ReadOnlySpan<char> path, int rootLen
         [return: NotNullIfNotNull(nameof(path))]
         internal static string? TrimEndingDirectorySeparator(string? path) =>
             EndsInDirectorySeparator(path) && !IsRoot(path.AsSpan()) ?
-                path!.Substring(0, path.Length - 1) :
+                path.Substring(0, path.Length - 1) :
                 path;
 
         /// <summary>