Skip to content

Commit 9786c47

Browse files
committed
Address PR feedback
1 parent 5c771e1 commit 9786c47

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

src/coreclr/interpreter/compiler.cpp

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,12 @@
11
// Licensed to the .NET Foundation under one or more agreements.
22
// The .NET Foundation licenses this file to you under the MIT license.
33
#include "gcinfoencoder.h"
4+
5+
// HACK: debugreturn.h (included by gcinfoencoder.h) breaks constexpr
6+
#if defined(debug_instrumented_return) || defined(_DEBUGRETURN_H_)
7+
#undef return
8+
#endif // debug_instrumented_return
9+
410
#include "interpreter.h"
511

612
#include <inttypes.h>
@@ -35,7 +41,7 @@ static const InterpType g_interpTypeFromStackType[] =
3541
};
3642

3743
// Used by assertAbort
38-
thread_local ICorJitInfo* gInterpJitInfoTls = nullptr;
44+
thread_local ICorJitInfo* t_InterpJitInfoTls = nullptr;
3945

4046
static const char *g_stackTypeString[] = { "I4", "I8", "R4", "R8", "O ", "VT", "MP", "F " };
4147

@@ -902,7 +908,7 @@ InterpCompiler::InterpCompiler(COMP_HANDLE compHnd,
902908
CORINFO_METHOD_INFO* methodInfo)
903909
{
904910
// Fill in the thread-local used for assertions
905-
gInterpJitInfoTls = compHnd;
911+
t_InterpJitInfoTls = compHnd;
906912

907913
m_methodHnd = methodInfo->ftn;
908914
m_compScopeHnd = methodInfo->scope;
@@ -3466,8 +3472,8 @@ void InterpCompiler::PrintCompiledIns(const int32_t *ip, const int32_t *start)
34663472

34673473
extern "C" void assertAbort(const char* why, const char* file, unsigned line)
34683474
{
3469-
if (gInterpJitInfoTls) {
3470-
if (!gInterpJitInfoTls->doAssert(file, line, why))
3475+
if (t_InterpJitInfoTls) {
3476+
if (!t_InterpJitInfoTls->doAssert(file, line, why))
34713477
return;
34723478
}
34733479

src/coreclr/interpreter/interpreter.h

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,6 @@
1616
#include <malloc.h>
1717
#endif
1818

19-
// HACK: debugreturn.h breaks constexpr
20-
#if defined(debug_instrumented_return) || defined(_DEBUGRETURN_H_)
21-
#undef return
22-
#endif // debug_instrumented_return
23-
2419
#include <algorithm>
2520

2621
#include "corhdr.h"

src/coreclr/vm/interpexec.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55

66
#include "threads.h"
77
#include "gcenv.h"
8-
#include <math.h>
98
#include "interpexec.h"
109

1110
typedef void* (*HELPER_FTN_PP)(void*);

0 commit comments

Comments
 (0)