-
Notifications
You must be signed in to change notification settings - Fork 282
Update Maui version flows #4321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
LoopedBard3
merged 14 commits into
dotnet:main
from
LoopedBard3:UpdateMauiVersionRetrievalFlow
Aug 1, 2024
Merged
Update Maui version flows #4321
LoopedBard3
merged 14 commits into
dotnet:main
from
LoopedBard3:UpdateMauiVersionRetrievalFlow
Aug 1, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ons for Performance Maui.
…de the band version.
3 tasks
4956c15
to
9b15cd1
Compare
…kload version, but still working on figuring out a good solution for the band version.
… for maui rollback file generation, matching either default (generated from sdk version) or a hardcoded version.
…ui and update 8.0 maui to not use a specific version at all.
This reverts commit d42ee45.
…rollback to make viewing it during a run easier.
…an be called directly for runtime maui version stuff.
In general, the logic looks good getting the values. Just have some questions on some of the additional data that we are using as part of the processing. |
caaavik-msft
previously approved these changes
Jul 31, 2024
2758618
to
ba84ed7
Compare
DrewScoggins
approved these changes
Aug 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update how we determine dotnet version to use and rollback versions for Performance Maui.
Version.Details.XML update from: #4327.
Darc subscription still needs to be setup.
Full test run: https://dev.azure.com/dnceng/internal/_build/results?buildId=2506223&view=results