Skip to content

Update Maui version flows #4321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Aug 1, 2024

Conversation

LoopedBard3
Copy link
Member

@LoopedBard3 LoopedBard3 commented Jul 18, 2024

Update how we determine dotnet version to use and rollback versions for Performance Maui.

Version.Details.XML update from: #4327.
Darc subscription still needs to be setup.

Full test run: https://dev.azure.com/dnceng/internal/_build/results?buildId=2506223&view=results

@LoopedBard3 LoopedBard3 added bug Something isn't working enhancement New feature or request lab-infrastructure labels Jul 18, 2024
@LoopedBard3 LoopedBard3 self-assigned this Jul 18, 2024
…kload version, but still working on figuring out a good solution for the band version.
… for maui rollback file generation, matching either default (generated from sdk version) or a hardcoded version.
…ui and update 8.0 maui to not use a specific version at all.
This reverts commit d42ee45.
@LoopedBard3 LoopedBard3 marked this pull request as ready for review July 25, 2024 22:56
…rollback to make viewing it during a run easier.
…an be called directly for runtime maui version stuff.
@LoopedBard3 LoopedBard3 marked this pull request as draft July 29, 2024 21:59
@DrewScoggins
Copy link
Member

In general, the logic looks good getting the values. Just have some questions on some of the additional data that we are using as part of the processing.

@LoopedBard3 LoopedBard3 requested a review from DrewScoggins July 31, 2024 20:50
caaavik-msft
caaavik-msft previously approved these changes Jul 31, 2024
@LoopedBard3 LoopedBard3 force-pushed the UpdateMauiVersionRetrievalFlow branch from 2758618 to ba84ed7 Compare July 31, 2024 21:44
@LoopedBard3 LoopedBard3 requested a review from caaavik-msft July 31, 2024 21:46
Copy link
Member

@DrewScoggins DrewScoggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LoopedBard3 LoopedBard3 enabled auto-merge (squash) August 1, 2024 21:30
@LoopedBard3 LoopedBard3 disabled auto-merge August 1, 2024 21:30
@LoopedBard3 LoopedBard3 merged commit 7ac5c58 into dotnet:main Aug 1, 2024
51 of 63 checks passed
@LoopedBard3 LoopedBard3 deleted the UpdateMauiVersionRetrievalFlow branch August 1, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request lab-infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants