CA2016 Forward the 'CancellationToken' parameter to methods that take… (#7188)

elachlan · web-flow · commit aeeb547c8a7b · 2022-01-10T08:15:07.000-08:00
* CA2016 Forward the 'CancellationToken' parameter to methods that take one

* Revert CodeAnalysis.ruleset

* enable warning on CA2016
diff --git a/eng/Common.globalconfig b/eng/Common.globalconfig
@@ -352,7 +352,7 @@ dotnet_diagnostic.CA2014.severity = warning
 dotnet_diagnostic.CA2015.severity = warning
 
 # Forward the 'CancellationToken' parameter to methods that take one
-dotnet_diagnostic.CA2016.severity = suggestion
+dotnet_diagnostic.CA2016.severity = warning
 
 # Review SQL queries for security vulnerabilities
 dotnet_diagnostic.CA2100.severity = none
diff --git a/src/Build.UnitTests/ProjectCache/ProjectCacheTests.cs b/src/Build.UnitTests/ProjectCache/ProjectCacheTests.cs
@@ -305,7 +305,7 @@ public override async Task<CacheResult> GetCacheResultAsync(
 
                 if (_projectQuerySleepTime is not null)
                 {
-                    await Task.Delay(_projectQuerySleepTime.Value);
+                    await Task.Delay(_projectQuerySleepTime.Value, cancellationToken);
                 }
 
                 QueryStartStops.Enqueue(queryId);

Original file line number	Diff line number	Diff line change
`@@ -305,7 +305,7 @@ public override async Task<CacheResult> GetCacheResultAsync(`
`305`	`305`
`306`	`306`	`if (_projectQuerySleepTime is not null)`
`307`	`307`	`{`
`308`		`- await Task.Delay(_projectQuerySleepTime.Value);`
	`308`	`+ await Task.Delay(_projectQuerySleepTime.Value, cancellationToken);`
`309`	`309`	`}`
`310`	`310`
`311`	`311`	`QueryStartStops.Enqueue(queryId);`