[src] Remove the NO_SYSTEM_DRAWING conditional compilation define, it's never set. #24479
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes all instances of the NO_SYSTEM_DRAWING conditional compilation define throughout the source code, which was never set and therefore always evaluated to false. The removal makes the previously conditionally compiled code for System.Drawing types unconditional.
- Removes all
#if !NO_SYSTEM_DRAWINGand corresponding#endifdirectives - Makes
using System.Drawing;statements unconditional across all affected files - Exposes System.Drawing type conversion operators and methods that were previously conditionally compiled
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/SpriteKit/SKKeyframeSequence.cs | Removes conditional around using System.Drawing; |
| src/ObjCRuntime/Dlfcn.cs | Moves using System.Drawing; before #if !COREBUILD block and removes the NO_SYSTEM_DRAWING conditional |
| src/Foundation/NSObject2.cs | Removes conditionals around using System.Drawing; and SizeF/RectangleF/PointF conversion code |
| src/CoreGraphics/CGSize.cs | Removes conditionals around using System.Drawing; and SizeF conversion operators |
| src/CoreGraphics/CGRect.cs | Removes conditionals around using System.Drawing; and RectangleF conversion operators |
| src/CoreGraphics/CGPoint.cs | Removes conditionals around using System.Drawing; and PointF conversion operators |
| src/CoreGraphics/CGEventTypes.cs | Removes conditional around using System.Drawing; |
| src/AppKit/NSOpenGLContext.cs | Removes conditionals around using System.Drawing; and SwapRectangle property |
✅ [PR Build #d0b7272] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
✅ [CI Build #d0b7272] Build passed (Build packages) ✅Pipeline on Agent |
✅ [CI Build #d0b7272] Build passed (Build macOS tests) ✅Pipeline on Agent |
💻 [CI Build #d0b7272] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build #d0b7272] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build #d0b7272] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
❌ [CI Build #d0b7272] Tests on macOS arm64 - Mac Sequoia (15) failed ❌Failed tests are:
Pipeline on Agent |
❌ [CI Build #d0b7272] Tests on macOS arm64 - Mac Tahoe (26) failed ❌Failed tests are:
Pipeline on Agent |
🔥 [CI Build #d0b7272] Test results 🔥Test results❌ Tests failed on VSTS: test results 0 tests crashed, 2 tests failed, 115 tests passed. Failures❌ dotnettests tests (Multiple platforms)1 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ monotouch tests (tvOS)1 tests failed, 8 tests passed.Failed tests
Html Report (VSDrops) Download Successes✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
No description provided.