Skip to content

Commit 6ea65cb

Browse files
committed
[tests] Add net6.0 TargetFramework.
1 parent 4277ac9 commit 6ea65cb

File tree

18 files changed

+48
-32
lines changed

18 files changed

+48
-32
lines changed

build-tools/automation/templates/core-tests.yaml

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -7,56 +7,56 @@ steps:
77
displayName: 'Tests: generator'
88
inputs:
99
command: test
10-
arguments: bin/Test$(Build.Configuration)/generator-Tests.dll
10+
arguments: bin/Test$(Build.Configuration)$(NetCoreTargetFrameworkPathSuffix)/generator-Tests.dll
1111
continueOnError: true
1212

1313
- task: DotNetCoreCLI@2
1414
displayName: 'Tests: JavaCallableWrappers'
1515
inputs:
1616
command: test
17-
arguments: bin/Test$(Build.Configuration)/Java.Interop.Tools.JavaCallableWrappers-Tests.dll
17+
arguments: bin/Test$(Build.Configuration)$(NetCoreTargetFrameworkPathSuffix)/Java.Interop.Tools.JavaCallableWrappers-Tests.dll
1818
continueOnError: true
1919

2020
- task: DotNetCoreCLI@2
2121
displayName: 'Tests: logcat-parse'
2222
inputs:
2323
command: test
24-
arguments: bin/Test$(Build.Configuration)/logcat-parse-Tests.dll
24+
arguments: bin/Test$(Build.Configuration)$(NetCoreTargetFrameworkPathSuffix)/logcat-parse-Tests.dll
2525
continueOnError: true
2626

2727
- task: DotNetCoreCLI@2
2828
displayName: 'Tests: ApiXmlAdjuster'
2929
inputs:
3030
command: test
31-
arguments: bin/Test$(Build.Configuration)/Xamarin.Android.Tools.ApiXmlAdjuster-Tests.dll
31+
arguments: bin/Test$(Build.Configuration)$(NetCoreTargetFrameworkPathSuffix)/Xamarin.Android.Tools.ApiXmlAdjuster-Tests.dll
3232
continueOnError: true
3333

3434
- task: DotNetCoreCLI@2
3535
displayName: 'Tests: Bytecode'
3636
inputs:
3737
command: test
38-
arguments: bin/Test$(Build.Configuration)/Xamarin.Android.Tools.Bytecode-Tests.dll
38+
arguments: bin/Test$(Build.Configuration)$(NetCoreTargetFrameworkPathSuffix)/Xamarin.Android.Tools.Bytecode-Tests.dll
3939
continueOnError: true
4040

4141
- task: DotNetCoreCLI@2
4242
displayName: 'Tests: Java.Interop.Tools.Generator'
4343
inputs:
4444
command: test
45-
arguments: bin/Test$(Build.Configuration)/Java.Interop.Tools.Generator-Tests.dll
45+
arguments: bin/Test$(Build.Configuration)$(NetCoreTargetFrameworkPathSuffix)/Java.Interop.Tools.Generator-Tests.dll
4646
continueOnError: true
4747

4848
- task: DotNetCoreCLI@2
4949
displayName: 'Tests: Java.Interop.Tools.JavaSource'
5050
inputs:
5151
command: test
52-
arguments: bin/Test$(Build.Configuration)/Java.Interop.Tools.JavaSource-Tests.dll
52+
arguments: bin/Test$(Build.Configuration)$(NetCoreTargetFrameworkPathSuffix)/Java.Interop.Tools.JavaSource-Tests.dll
5353
continueOnError: true
5454

5555
- task: DotNetCoreCLI@2
5656
displayName: 'Tests: Xamarin.SourceWriter'
5757
inputs:
5858
command: test
59-
arguments: bin/Test$(Build.Configuration)/Xamarin.SourceWriter-Tests.dll
59+
arguments: bin/Test$(Build.Configuration)$(NetCoreTargetFrameworkPathSuffix)/Xamarin.SourceWriter-Tests.dll
6060
continueOnError: true
6161

6262
- task: DotNetCoreCLI@2
@@ -80,15 +80,15 @@ steps:
8080
condition: eq('${{ parameters.runNativeTests }}', 'true')
8181
inputs:
8282
command: test
83-
arguments: bin/Test$(Build.Configuration)/Java.Interop.Dynamic-Tests.dll
83+
arguments: bin/Test$(Build.Configuration)$(NetCoreTargetFrameworkPathSuffix)/Java.Interop.Dynamic-Tests.dll
8484
continueOnError: true
8585

8686
- task: DotNetCoreCLI@2
8787
displayName: 'Tests: Java.Interop.Export'
8888
condition: eq('${{ parameters.runNativeTests }}', 'true')
8989
inputs:
9090
command: test
91-
arguments: bin/Test$(Build.Configuration)/Java.Interop.Export-Tests.dll
91+
arguments: bin/Test$(Build.Configuration)$(NetCoreTargetFrameworkPathSuffix)/Java.Interop.Export-Tests.dll
9292
continueOnError: true
9393

9494
- task: DotNetCoreCLI@2

src/Xamarin.Android.Tools.Bytecode/ConstantPool.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -260,7 +260,7 @@ public float Value {
260260

261261
public override string ToString ()
262262
{
263-
return string.Format (CultureInfo.InvariantCulture, "Float({0})", Value);
263+
return string.Format (CultureInfo.InvariantCulture, "Float({0:G9})", Value);
264264
}
265265
}
266266

@@ -329,7 +329,7 @@ public double Value {
329329

330330
public override string ToString ()
331331
{
332-
return string.Format (CultureInfo.InvariantCulture, "Double({0})", Value);
332+
return string.Format (CultureInfo.InvariantCulture, "Double({0:G17})", Value);
333333
}
334334
}
335335

src/Xamarin.Android.Tools.Bytecode/XmlClassDeclarationBuilder.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -529,7 +529,7 @@ static XAttribute GetValue (FieldInfo field)
529529
else if (Double.IsPositiveInfinity (doubleItem.Value))
530530
value = "(1.0 / 0.0)";
531531
else
532-
value = doubleItem.Value.ToString ("R", CultureInfo.InvariantCulture);
532+
value = doubleItem.Value.ToString ("G17", CultureInfo.InvariantCulture);
533533
break;
534534
case ConstantPoolItemType.Float:
535535
var floatItem = (ConstantPoolFloatItem) constant;
@@ -540,7 +540,7 @@ static XAttribute GetValue (FieldInfo field)
540540
else if (Double.IsPositiveInfinity (floatItem.Value))
541541
value = "(1.0f / 0.0f)";
542542
else
543-
value = floatItem.Value.ToString ("R", CultureInfo.InvariantCulture);
543+
value = floatItem.Value.ToString ("G9", CultureInfo.InvariantCulture);
544544
break;
545545
case ConstantPoolItemType.Long: value = ((ConstantPoolLongItem) constant).Value.ToString (); break;
546546
case ConstantPoolItemType.Integer:

tests/Java.Interop.Dynamic-Tests/Java.Interop.Dynamic-Tests.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22

33
<PropertyGroup>
4-
<TargetFramework>net472</TargetFramework>
4+
<TargetFrameworks>net472;net6.0</TargetFrameworks>
55
<IsPackable>false</IsPackable>
66
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
77
</PropertyGroup>

tests/Java.Interop.Export-Tests/Java.Interop.Export-Tests.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22

33
<PropertyGroup>
4-
<TargetFramework>net472</TargetFramework>
4+
<TargetFrameworks>net472;net6.0</TargetFrameworks>
55
<IsPackable>false</IsPackable>
66
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
77
</PropertyGroup>

tests/Java.Interop.Export-Tests/Java.Interop/MarshalMemberBuilderTest.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212

1313
namespace Java.InteropTests
1414
{
15+
#if !NET
1516
[TestFixture]
1617
class MarshalMemberBuilderTest : JavaVMFixture
1718
{
@@ -555,4 +556,5 @@ public void CreateConstructActivationPeerExpression ()
555556
}}");
556557
}
557558
}
559+
#endif
558560
}

tests/Java.Interop.Tools.Generator-Tests/Java.Interop.Tools.Generator-Tests.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22

33
<PropertyGroup>
4-
<TargetFramework>net472</TargetFramework>
4+
<TargetFrameworks>net472;net6.0</TargetFrameworks>
55
<RootNamespace>Java.Interop.Tools.Common_Tests</RootNamespace>
66
<IsPackable>false</IsPackable>
77
</PropertyGroup>

tests/Java.Interop.Tools.JavaCallableWrappers-Tests/Java.Interop.Tools.JavaCallableWrappers-Tests.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22

33
<PropertyGroup>
4-
<TargetFramework>net472</TargetFramework>
4+
<TargetFrameworks>net472;net6.0</TargetFrameworks>
55
<IsPackable>false</IsPackable>
66
<DefineConstants>$(DefineConstants);HAVE_CECIL;JCW_ONLY_TYPE_NAMES</DefineConstants>
77
</PropertyGroup>

tests/Java.Interop.Tools.JavaCallableWrappers-Tests/Java.Interop.Tools.JavaCallableWrappers/JavaNativeTypeManagerTests.cs

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,12 @@ public void TearDown ()
2929
public void Crc64 ()
3030
{
3131
JavaNativeTypeManager.PackageNamingPolicy = PackageNamingPolicy.LowercaseCrc64;
32+
#if NET
33+
// System.String moved assemblies in .NET
34+
Assert.AreEqual ("crc64d04135c992393d83", JavaNativeTypeManager.GetPackageName (typeof (string)));
35+
#else
3236
Assert.AreEqual ("crc64b74743e9328eed0a", JavaNativeTypeManager.GetPackageName (typeof (string)));
37+
#endif
3338
}
3439

3540
[Test]
@@ -43,7 +48,12 @@ public void Lowercase ()
4348
public void LowercaseWithAssemblyName ()
4449
{
4550
JavaNativeTypeManager.PackageNamingPolicy = PackageNamingPolicy.LowercaseWithAssemblyName;
51+
#if NET
52+
// System.String moved assemblies in .NET
53+
Assert.AreEqual ("assembly_system_private_corelib.system", JavaNativeTypeManager.GetPackageName (typeof (string)));
54+
#else
4655
Assert.AreEqual ("assembly_mscorlib.system", JavaNativeTypeManager.GetPackageName (typeof (string)));
56+
#endif
4757
}
4858
}
4959
}

tests/Java.Interop.Tools.JavaSource-Tests/Java.Interop.Tools.JavaSource-Tests.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22
<PropertyGroup>
3-
<TargetFramework>net472</TargetFramework>
3+
<TargetFrameworks>net472;net6.0</TargetFrameworks>
44
<IsPackable>False</IsPackable>
55
</PropertyGroup>
66
<PropertyGroup>

0 commit comments

Comments
 (0)