Commit 39a3b87
authored
[ApiXmlAdjuster] Add additional expected attributes (#476)
Context: dotnet/android#3223
Context: https://jenkins.mono-project.com/job/xamarin-android-pr-pipeline-debug/619/
Commit a30523e breaks the xamarin-android build, as it introduces new
XML attributes to `class-parse` output which
`Xamarin.Android.Tools.ApiXmlAdjuster` doesn't appreciate:
Unhandled Exception:
System.Exception: …/xamarin-android/bin/BuildDebug/api/api-10.xml.class-parse (16,7): Element 'class' has an unexpected attribute: 'source-file-name'. Expected attributes are: source-file-name
at Xamarin.Android.Tools.ApiXmlAdjuster.XmlUtil.CheckExtraneousAttributes (System.String elementName, System.Xml.XmlReader reader, System.String[] expected)
at Xamarin.Android.Tools.ApiXmlAdjuster.JavaApiLoaderExtensions.LoadTypeAttributes (Xamarin.Android.Tools.ApiXmlAdjuster.JavaType type, System.Xml.XmlReader reader, System.String[] otherAllowedAttributes)
at Xamarin.Android.Tools.ApiXmlAdjuster.JavaApiLoaderExtensions.Load (Xamarin.Android.Tools.ApiXmlAdjuster.JavaClass kls, System.Xml.XmlReader reader)
Update `Xamarin.Android.Tools.ApiXmlAdjuster` so that the new
attributes introduced in a30523e are considered acceptable.
Additionally, fix the error message so that it *actually* lists the
"expected attributes", instead of repeating the *un*-expected attribute.1 parent 6dd1cf4 commit 39a3b87
File tree
2 files changed
+6
-2
lines changed- src/Xamarin.Android.Tools.ApiXmlAdjuster
2 files changed
+6
-2
lines changedLines changed: 5 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
84 | 84 | | |
85 | 85 | | |
86 | 86 | | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
87 | 90 | | |
| 91 | + | |
88 | 92 | | |
| 93 | + | |
89 | 94 | | |
90 | 95 | | |
91 | | - | |
92 | 96 | | |
93 | 97 | | |
94 | 98 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
27 | | - | |
| 27 | + | |
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
| |||
0 commit comments