Skip to content

New Observability topic #35881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 34 commits into from
Jun 29, 2023
Merged

New Observability topic #35881

merged 34 commits into from
Jun 29, 2023

Conversation

samsp-msft
Copy link
Contributor

@samsp-msft samsp-msft commented Jun 19, 2023

Summary

New document to provide an overview of Observability options and how to use Otel with .NET.

Shows metrics with prometheus & graphana and tracing with Jaeger.
Shows logs, metrics & tracing with app-insights

Fixes #Issue_Number (if available)


Internal previews

📄 File 🔗 Preview link
docs/core/diagnostics/observability-with-otel.md docs/core/diagnostics/observability-with-otel

@samsp-msft
Copy link
Contributor Author

@bradygaster - I'd like your take on how deep we should go here
@mattmccleary - is there more info we should add here on OTel - I want to strike a balance of enough info here without having to update monthly based on new updates in OTel
@poppastring - I started adding dotnet-monitor, but as its not currently optimized for 24x7 egress, I don't know whether to include it or not.

Copy link

@mattmccleary mattmccleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samsp-msft samsp-msft marked this pull request as ready for review June 21, 2023 17:04
@samsp-msft samsp-msft requested review from tommcdon and a team as code owners June 21, 2023 17:04
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a bunch of suggestions to consider.

Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a bunch of suggestions to consider.

samsp-msft and others added 2 commits June 21, 2023 13:01
Amazing edit review by @gewarren

Co-authored-by: Genevieve Warren <[email protected]>
Co-authored-by: Genevieve Warren <[email protected]>
undoing my tendancy to call grafana as graphana
Copy link
Member

@noahfalk noahfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice overview 👍

@samsp-msft
Copy link
Contributor Author

@gewarren - I have a couple of benign warnings from the learn build service - I think they are what is blocking this.

• Line 118, Column 1: [Warning] Unrecognized language value '.csproj' in code snippet 'Snippet_References' in file 'snippets/OTel-Prometheus-grafana-Jaeger/csharp/OTel-Prometheus-Grafana-Jaeger.csproj'. Your code snippet might not render correctly. If this is the case, you can request a new value or use range instead.
• Line 388, Column 1: [Warning] Unrecognized language value '.csproj' in code snippet 'Snippet_AZMReferences' in file 'snippets/OTel-Prometheus-grafana-Jaeger/csharp/OTel-Prometheus-Grafana-Jaeger.csproj'. Your code snippet might not render correctly. If this is the case, you can request a new value or use range instead.
• Line 285, Column 232: [Suggestion] Link 'http://localhost:3000' points to a page that doesn't exist. Check the path or URL and update the link.
• Line 352, Column 49: [Suggestion] Link 'http://localhost:16686/' points to a page that doesn't exist. Check the path or URL and update the link.

The csproj work fine in the output, and the links are to services that are created by following the directions in the topic.

@meganbradley
Copy link
Contributor

@gewarren @samsp-msft Is there an exception process for merging with warnings in the dotnet repo? It seems the blocker is a custom check for this repo - ordinarily PRs with warnings can be merged by someone with perms.

@gewarren
Copy link
Contributor

@gewarren @samsp-msft Is there an exception process for merging with warnings in the dotnet repo? It seems the blocker is a custom check for this repo - ordinarily PRs with warnings can be merged by someone with perms.

@meganbradley Yes, I can remove that check from branch protection rules and merge this PR, but I don't want to have this warning in the repo because it will show up in other PRs too.

@samsp-msft samsp-msft merged commit 1a89d1b into main Jun 29, 2023
@samsp-msft samsp-msft deleted the samsp/observability branch June 29, 2023 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants