-
Notifications
You must be signed in to change notification settings - Fork 6k
New Observability topic #35881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Observability topic #35881
Conversation
…into samsp/observability
@bradygaster - I'd like your take on how deep we should go here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a bunch of suggestions to consider.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a bunch of suggestions to consider.
Amazing edit review by @gewarren Co-authored-by: Genevieve Warren <[email protected]>
Co-authored-by: Genevieve Warren <[email protected]>
undoing my tendancy to call grafana as graphana
docs/core/diagnostics/snippets/OTel-Prometheus-Grafana-Yaeger/csharp/Program.cs
Outdated
Show resolved
Hide resolved
docs/core/diagnostics/snippets/OTel-Prometheus-Grafana-Yaeger/csharp/Program.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice overview 👍
docs/core/diagnostics/snippets/OTel-Prometheus-Grafana-Yaeger/csharp/Program.cs
Outdated
Show resolved
Hide resolved
docs/core/diagnostics/snippets/OTel-Prometheus-Grafana-Yaeger/csharp/Program.cs
Outdated
Show resolved
Hide resolved
…into samsp/observability
@gewarren - I have a couple of benign warnings from the learn build service - I think they are what is blocking this. • Line 118, Column 1: [Warning] Unrecognized language value '.csproj' in code snippet 'Snippet_References' in file 'snippets/OTel-Prometheus-grafana-Jaeger/csharp/OTel-Prometheus-Grafana-Jaeger.csproj'. Your code snippet might not render correctly. If this is the case, you can request a new value or use range instead. The csproj work fine in the output, and the links are to services that are created by following the directions in the topic. |
@gewarren @samsp-msft Is there an exception process for merging with warnings in the dotnet repo? It seems the blocker is a custom check for this repo - ordinarily PRs with warnings can be merged by someone with perms. |
@meganbradley Yes, I can remove that check from branch protection rules and merge this PR, but I don't want to have this warning in the repo because it will show up in other PRs too. |
Summary
New document to provide an overview of Observability options and how to use Otel with .NET.
Shows metrics with prometheus & graphana and tracing with Jaeger.
Shows logs, metrics & tracing with app-insights
Fixes #Issue_Number (if available)
Internal previews