Update manifest breaking change #18306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@IEvangelist Ping for review when you get a chance. The warnings are standard for include files. |
IEvangelist
reviewed
May 8, 2020
|
Thanks David! |
|
Thanks Ben! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the previous way this was written, it included a bunch of (useful) information that wasn't directly related to the breaking change. It wasn't clear what exactly the breaking change was, also because of some misinformation in the doc. This PR strips out the unrelated information. I'll add a new, separate article that details how manifest file names are chosen in #18304.
Also adds this to the .NET Framework -> .NET Core breaking changes page.
Internal preview link.
Contributes to #16964.