This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Fix the reference assembly for mscorlib to match the surface area of the OS #4890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexGhiondea
force-pushed
the
BuildRefAssemblyPerTargetOS
branch
from
ea19122 to
94107cd
Compare
|
@AlexGhiondea @mikem8361 is this the same mac error we've been seeing for a while? |
|
This is a failure in the PAL tests not the semaphore/disk full problem. I think @sergiy-k is looking at this one. |
…the OS on which it builds.
AlexGhiondea
force-pushed
the
BuildRefAssemblyPerTargetOS
branch
from
94107cd to
3368e3f
Compare
| <Version>1.0.1</Version> | ||
| <SkipPackageFileCheck>true</SkipPackageFileCheck> | ||
| <SkipValidatePackage>true</SkipValidatePackage> | ||
| <PackagePlatforms>x64;x86;arm</PackagePlatforms> |
There was a problem hiding this comment.
We shouldn't need all these architectures. Just one should do as it is just a reference assembly.
Make sure that the facade projects generates pdbs when possible.
AlexGhiondea
force-pushed
the
BuildRefAssemblyPerTargetOS
branch
from
3368e3f to
b451522
Compare
kyulee1
added a commit
to kyulee1/coreclr
that referenced
this pull request
Jun 16, 2016
I think this finally fixes most of long outstanding GC issues that appear in different forms so far that include #4877, #4879, dotnet#4890 and more. The issues was WriteBarrier implementation. When we update card table, the address has been already incremented by 8. With this fix, all corefx tests seem to run on xunit framework without crashing. I verified this with an out-of-date build locally, so there are not found assembly errors like System.Runtime.Extensions with different versions, though. These are what I tested so far that safely finished all runs with very high percentage of pass. System.Collections.Tests System.Dynamic.Runtime.Tests System.Linq.Expressions.Tests System.Linq.Parallel.Tests Potentially more coreclr tests will pass. I will update them as tests go.
kyulee1
added a commit
to kyulee1/coreclr
that referenced
this pull request
Jun 16, 2016
I think this finally fixes most of long outstanding GC issues that appear in different forms so far that include #4877, #4879, dotnet#4890 and more. The issues was WriteBarrier implementation. When we update card table, the address has been already incremented by 8. With this fix, all corefx tests seem to run on xunit framework without crashing. I verified this with an out-of-date build locally, so there are not found assembly errors like System.Runtime.Extensions with different versions, though. These are what I tested so far that safely finished all runs with very high percentage of pass. System.Collections.Tests System.Dynamic.Runtime.Tests System.Linq.Expressions.Tests System.Linq.Parallel.Tests Potentially more coreclr tests will pass. I will update them as tests go.
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…mblyPerTargetOS Fix the reference assembly for mscorlib to match the surface area of the OS Commit migrated from dotnet/coreclr@b59a604
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
I think this finally fixes most of long outstanding GC issues that appear in different forms so far that include dotnet/coreclr#4877, dotnet/coreclr#4879, dotnet/coreclr#4890 and more. The issues was WriteBarrier implementation. When we update card table, the address has been already incremented by 8. With this fix, all corefx tests seem to run on xunit framework without crashing. I verified this with an out-of-date build locally, so there are not found assembly errors like System.Runtime.Extensions with different versions, though. These are what I tested so far that safely finished all runs with very high percentage of pass. System.Collections.Tests System.Dynamic.Runtime.Tests System.Linq.Expressions.Tests System.Linq.Parallel.Tests Potentially more coreclr tests will pass. I will update them as tests go. Commit migrated from dotnet/coreclr@49c2eec
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will enable the facade generation across the OSes.