This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Update BuildTools, CoreClr, CoreFx, PgoData to preview1-02929-01, preview1-26629-04, preview1-26628-03, master-20180629-0054, respectively (master) #18694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pjanotti Looks like dotnet/buildtools#2077 broke the CoreCLR build. |
|
Looking... |
|
I couldn't repro on my machine, it also seems related to perf runs (the failure on the Innerloop looks like a test failure). Noticed that on the perf run failures we are using VS2015 tooling (which is not the case for Innerloop). |
|
Discarded CI Status: 5:x: 17:heavy_check_mark: (click to expand)
|
dotnet-maestro-bot
force-pushed
the
master-UpdateDependencies
branch
from
fb96bc5 to
9e697a6
Compare
dotnet-maestro-bot
changed the title
|
I got a repro using the VS2015 tools, let me see if I can fix instead of reverting my changes... |
|
VS2015 tools are less forgiving: the two tasks that I added to tests.targets were under an ItemGroup and that is fine for VS2017 tools, but for VS2015 they need to be at the Target level. |
|
Discarded CI Status: 4:x: 18:heavy_check_mark: (click to expand)
|
dotnet-maestro-bot
changed the title
dotnet-maestro-bot
force-pushed
the
master-UpdateDependencies
branch
from
9e697a6 to
7611a89
Compare
|
Discarded CI Status: 1:x: 21:heavy_check_mark: (click to expand)
|
dotnet-maestro-bot
force-pushed
the
master-UpdateDependencies
branch
from
7611a89 to
e4af8f7
Compare
dotnet-maestro-bot
changed the title
|
Discarded CI Status: 22:heavy_check_mark: (click to expand)
|
…view1-26629-04, preview1-26628-03, master-20180629-0054, respectively
dotnet-maestro-bot
changed the title
dotnet-maestro-bot
force-pushed
the
master-UpdateDependencies
branch
from
e4af8f7 to
ce022b0
Compare
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…view1-26629-04, preview1-26628-03, master-20180629-0054, respectively (dotnet/coreclr#18694) Commit migrated from dotnet/coreclr@d96ac2c
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @dotnet/coreclr-auto-update-notify