This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Avoid capturing ExecutionContext into CancellationTokenSource's Timer #18670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not needed, and it can keep unrelated state alive unnecessarily
tarekgh
reviewed
Jun 27, 2018
| object state, | ||
| int dueTime, | ||
| int period, | ||
| bool flowExecutionContext) |
There was a problem hiding this comment.
why you didn't make this internal for now and we can expose it later? why we need to have UnsafeCreate at all?
There was a problem hiding this comment.
Just following the proposed API, which maps to things like ThreadPool.QueueUserWorkItem vs ThreadPool.UnsafeQueueUserWorkItem. I don't have a strong preference.
There was a problem hiding this comment.
I am really preferring the constructor over UnsafeCreate. having flowExecutionContext parameter is more useful to understand.
|
I added one question, other than that LGTM |
tarekgh
approved these changes
Jun 27, 2018
stephentoub
force-pushed
the
timerunsafecreate
branch
from
7d75157 to
0072c84
Compare
benaadams
approved these changes
Jun 28, 2018
|
Requested backport to 2.2 https://github.com/dotnet/corefx/issues/31969#issuecomment-416197153 |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…dotnet/coreclr#18670) * Avoid capturing ExecutionContext into CancellationTokenSource's Timer It's not needed, and it can keep unrelated state alive unnecessarily * Address PR feedback Commit migrated from dotnet/coreclr@7d72463
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not needed, and it can keep unrelated state alive unnecessarily.
Contributes to https://github.com/dotnet/corefx/issues/26523
Contributes to https://github.com/dotnet/corefx/issues/30670
cc: @kouvel, @tarekgh, @benaadams