This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Fix build for Alpine Linux #205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jasonwilliams200OK, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! The agreement was validated by .NET Foundation and real humans are currently evaluating your PR. TTYL, DNFBOT; |
Alpine Linux uses musl-libc and Android uses bionic; what both have in common is `__GLIBC__` unavailable. This fixes the condition in Casablanca header where an explicit `__ANDROID__` is used. Instead checking for `__GLIBC__` fixes the build for both platforms. Another fix is to include `<sys/time.h>` header which is required for `timeval` on some Unix platforms.
|
With this fix, I have able to take first step, build muxer binary (with libhostpolicy.so and libhostfxr.so) on Alpine Linux. git clone https://github.com/dotnet/core-setup
mkdir $HOME/muxer-build && cd $HOME/muxer-build
../core-setup/src/corehost/build.sh --arch x64 --hostver 1.0.2-beta-000559-00 \
--fxrver 1.0.2-beta-000559-00 --policyver 1.0.2-beta-000559-00 \
--rid alpine.3.4.0-x64 --commithash 3c8ad46cb09d1ac87159b2cc17cb410afb835c9bNow time to fiddle with |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alpine Linux uses musl-libc and Android uses bionic; what both have in
common is
__GLIBC__unavailable. This fixes the condition inCasablanca header where an explicit
__ANDROID__is used. Insteadchecking for
__GLIBC__fixes the build for both platforms.Another fix is to include
<sys/time.h>header which is required fortimevalon some Unix platforms.Progress towards: https://github.com/dotnet/coreclr/issues/917#issuecomment-229827373
/cc @schellap, @ericstj, @jkotas