Skip to content
This repository was archived by the owner on Apr 20, 2023. It is now read-only.

Fix dotnet store options #6631

Merged
merged 2 commits into from
May 19, 2017
Merged

Fix dotnet store options #6631

merged 2 commits into from
May 19, 2017

Conversation

eerhardt
Copy link
Member

  • remove configuration
  • remove preserve-working-dir
  • add skip-symbols

Fix #6488
Fix #6489
Fix #6490

Also fixes #1 of dotnet/sdk#1126 (comment). And along with dotnet/sdk#1231 should complete the feature.

@gkhanna79 @ramarag

/cc @bleroy @dotnet/dotnet-cli

- remove configuration
- remove preserve-working-dir
- add skip-symbols

Fix #6488
Fix #6489
Fix #6490
@livarcocc
Copy link

@eerhardt We are doing the ask mode template now for approval. You can see an example here: #6627. After filling up the template, tag matt for approval.

@eerhardt
Copy link
Member Author

Customer scenario

When first implementing dotnet store, we added 2 command line options that are confusing. configuration doesn't do anything for the command. And preserve-working-dir is an advanced/debugging scenario.

Removing those 2 options.

Also adding a new option to skip generating profiling symbols, as spec'd by the PM.

Bugs this fixes:

Fix #6488
Fix #6489
Fix #6490

Also fixes #1 of dotnet/sdk#1126 (comment). And along with dotnet/sdk#1231 should complete the feature.

Workarounds, if any
N/A

Risk

Low. The removed options aren't used by users, and we just added the whole command in 2.0.

Performance impact
None.

Is this a regression from a previous update?
No

Root cause analysis:
Planned Feature

How was the bug found?
Planned Feature

@MattGertz for approval

@eerhardt eerhardt merged commit 8c1dacb into dotnet:master May 19, 2017
@eerhardt eerhardt deleted the StoreOptions branch May 19, 2017 02:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants