Components: don't block the SignalR loop during init. Fixes #8274 #8863
Conversation
| for (var i = 0; i < Descriptors.Count; i++) | ||
| { | ||
| var (componentType, domElementSelector) = Descriptors[i]; | ||
| await Renderer.AddComponentAsync(componentType, domElementSelector); |
There was a problem hiding this comment.
Do we still have to work for quiescence here until we declare the circuit opened?
There was a problem hiding this comment.
No, if we did that, then JSInterop calls made in the meantime (e.g., during InitAsync) would throw because they are only allowed once the circuit is flagged as opened.
We need the circuit to be regarded as opened synchronously. Since dispatcher calls are serialized, and since (non-quiescent) rendering is synchronous, we already know that we'll only start to process incoming JSInterop calls after the first synchronous render, which is the right time to start processing them.
|
@javiercn I don't think we have any infrastructure for E2E tests specifically about initialization, since all our E2E tests run in a context where the app has already started running. I agree it would be good if we did have more coverage around that, but it's not something I'd like to get deep into at this point. |
Eilon
added
the
area-mvc
| @@ -64,7 +64,7 @@ public override Task OnDisconnectedAsync(Exception exception) | |||
| /// <summary> | |||
| /// Intended for framework use only. Applications should not call this method directly. | |||
| /// </summary> | |||
| public async Task<string> StartCircuit(string uriAbsolute, string baseUriAbsolute) | |||
| public string StartCircuit(string uriAbsolute, string baseUriAbsolute) | |||
| @@ -104,21 +104,32 @@ public Task<IEnumerable<string>> PrerenderComponentAsync(Type componentType, Par | |||
| }); | |||
| } | |||
|
|
|||
| public async Task InitializeAsync(CancellationToken cancellationToken) | |||
There was a problem hiding this comment.
It would be really nice to leave the signature alone and have the hub be the one to fire-and-forget this task. When we have async code we need to be able to await it in a test or errors will creep in.
Basically have a big, thick, gooey async method that returns a task, and have a small stub (StartCircuit in this case) do _ = InitializeAsync()
SteveSandersonMS
force-pushed
the
stevesa/fix-interop-during-init
branch
from
dd7a169 to
82018fc
Compare
SteveSandersonMS
force-pushed
the
stevesa/fix-interop-during-init
branch
from
82018fc to
50c31b8
Compare
For more details, see #8274 (comment)