Support conditional compression #8239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unrelated failure: https://github.com/aspnet/AspNetCore-Internal/issues/1778 @mikaelm12 |
javiercn
reviewed
Mar 6, 2019
|
@danroth27 @SteveSandersonMS this should directly improve Blazor |
JunTaoLuo
approved these changes
Mar 7, 2019
src/Middleware/ResponseCompression/test/ResponseCompressionMiddlewareTest.cs
Outdated
Show resolved
Hide resolved
jkotalik
reviewed
Mar 7, 2019
jkotalik
reviewed
Mar 7, 2019
jkotalik
reviewed
Mar 7, 2019
Tratcher
force-pushed
the
tratcher/compress
branch
from
c9678ae to
8f23484
Compare
| public enum HttpsCompressionMode | ||
| { | ||
| /// <summary> | ||
| /// No value has been specified, use the configured defaults. |
There was a problem hiding this comment.
Is there a "default" default? I'm not sure where I'd look to find the "configured defaults". Is the default hard-coded, or implied somewhere such that we could document it here?
There was a problem hiding this comment.
I.e. the global value at ResponseCompressionOptions.EnableForHttps
|
|
||
| /// <summary> | ||
| /// Opts out of compression over HTTPS. Enabling compression on HTTPS requests for remotely manipulable content | ||
| /// may expose security problems. |
There was a problem hiding this comment.
Is there any canonical or at least permanent place we could direct folks for more information? Do we have examples of other API ref docs that warn about potential security problems that we can follow form on?
amcasey
added
the
area-middleware
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6925 @DamianEdwards @glennc @blowdart this allows ResponseCompression's EnableForHttps setting to be overridden per request (opt in or opt out). StaticFiles opts in by default.