Skip to content

Update location of obj/ and bin/ directories to match Arcade conventions #7585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 15, 2019

Conversation

natemcmaster
Copy link
Contributor

Part of #7280

This moves obj/ and bin/ directories into artifacts/bin/ and artifacts/obj/ to match where they will be when we adopt Microsoft.DotNet.Arcade.Sdk.

cref https://github.com/dotnet/arcade/blob/master/Documentation/ArcadeSdk.md#single-build-output

@natemcmaster natemcmaster requested a review from dougbu February 14, 2019 19:39
@natemcmaster
Copy link
Contributor Author

@ryanbrandenburg can you think of any reason why changing the location of obj/ and bin/ would affect template tests?

Failed Templates.Test.SpaTemplateTest.ReactTemplateTest.ReactTemplate_Works_NetCore

Restoring NPM packages in '/home/vsts/work/1/s/src/ProjectTemplates/test/bin/Release/netcoreapp3.0/TestTemplates/AspNet.Template.3176cd/ClientApp' using npm...
==> bash -c "npm install" [/home/vsts/work/1/s/src/ProjectTemplates/test/bin/Release/netcoreapp3.0/TestTemplates/AspNet.Template.3176cd/ClientApp]

> [email protected] postinstall /home/vsts/work/1/s/src/ProjectTemplates/test/bin/Release/netcoreapp3.0/TestTemplates/AspNet.Template.3176cd/ClientApp/node_modules/uglifyjs-webpack-plugin
> node lib/post_install.js

[ERROR] npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/fsevents):
[ERROR] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
[ERROR] 
added 1362 packages from 847 contributors and audited 15215 packages in 40.621s
found 287 vulnerabilities (285 moderate, 2 high)
  run `npm audit fix` to fix them, or `npm audit` for details
==> bash -c "npm run lint" [/home/vsts/work/1/s/src/ProjectTemplates/test/bin/Release/netcoreapp3.0/TestTemplates/AspNet.Template.3176cd/ClientApp]

> [email protected] lint /home/vsts/work/1/s/src/ProjectTemplates/test/bin/Release/netcoreapp3.0/TestTemplates/AspNet.Template.3176cd/ClientApp
> eslint ./src/

[ERROR] Cannot find module 'typescript-eslint-parser'
[ERROR] Error: Cannot find module 'typescript-eslint-parser'
[ERROR]     at ModuleResolver.resolve (/home/vsts/work/1/s/src/ProjectTemplates/test/bin/Release/netcoreapp3.0/TestTemplates/AspNet.Template.3176cd/ClientApp/node_modules/eslint/lib/util/module-resolver.js:74:19)
[ERROR]     at loadFromDisk (/home/vsts/work/1/s/src/ProjectTemplates/test/bin/Release/netcoreapp3.0/TestTemplates/AspNet.Template.3176cd/ClientApp/node_modules/eslint/lib/config/config-file.js:509:42)
[ERROR]     at Object.load (/home/vsts/work/1/s/src/ProjectTemplates/test/bin/Release/netcoreapp3.0/TestTemplates/AspNet.Template.3176cd/ClientApp/node_modules/eslint/lib/config/config-file.js:559:20)
[ERROR]     at Config.getLocalConfigHierarchy (/home/vsts/work/1/s/src/ProjectTemplates/test/bin/Release/netcoreapp3.0/TestTemplates/AspNet.Template.3176cd/ClientApp/node_modules/eslint/lib/config.js:227:44)
[ERROR]     at Config.getConfigHierarchy (/home/vsts/work/1/s/src/ProjectTemplates/test/bin/Release/netcoreapp3.0/TestTemplates/AspNet.Template.3176cd/ClientApp/node_modules/eslint/lib/config.js:179:43)
[ERROR]     at Config.getConfigVector (/home/vsts/work/1/s/src/ProjectTemplates/test/bin/Release/netcoreapp3.0/TestTemplates/AspNet.Template.3176cd/ClientApp/node_modules/eslint/lib/config.js:286:21)
[ERROR]     at Config.getConfig (/home/vsts/work/1/s/src/ProjectTemplates/test/bin/Release/netcoreapp3.0/TestTemplates/AspNet.Template.3176cd/ClientApp/node_modules/eslint/lib/config.js:329:29)
[ERROR]     at processText (/home/vsts/work/1/s/src/ProjectTemplates/test/bin/Release/netcoreapp3.0/TestTemplates/AspNet.Template.3176cd/ClientApp/node_modules/eslint/lib/cli-engine.js:163:33)
[ERROR]     at processFile (/home/vsts/work/1/s/src/ProjectTemplates/test/bin/Release/netcoreapp3.0/TestTemplates/AspNet.Template.3176cd/ClientApp/node_modules/eslint/lib/cli-engine.js:224:18)
[ERROR]     at fileList.map.fileInfo (/home/vsts/work/1/s/src/ProjectTemplates/test/bin/Release/netcoreapp3.0/TestTemplates/AspNet.Template.3176cd/ClientApp/node_modules/eslint/lib/cli-engine.js:550:20)
[ERROR] npm ERR! code ELIFECYCLE
[ERROR] npm ERR! errno 1
[ERROR] npm ERR! [email protected] lint: `eslint ./src/`
[ERROR] npm ERR! Exit status 1
[ERROR] npm ERR! 
[ERROR] npm ERR! Failed at the [email protected] lint script.

@natemcmaster
Copy link
Contributor Author

natemcmaster commented Feb 14, 2019

@ryanbrandenburg nevermind. Looks like this is already known - https://github.com/aspnet/AspNetCore-Internal/issues/1745. @mkArtakMSFT are you okay if I skip this test? There have been 6 failures in the last 4 hours

@natemcmaster natemcmaster merged commit 6defaad into master Feb 15, 2019
@natemcmaster natemcmaster deleted the namc/obj-bin branch February 15, 2019 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants