Fix discrepancy between Version.Details.xml and Versions.props #7314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pakrym
approved these changes
Feb 6, 2019
dougbu
reviewed
Feb 6, 2019
|
|
||
| 1. Create the .csproj | ||
| 2. Run `eng/scripts/GenerateProjectList.ps1` | ||
| 3. Add it to Extensions.sln |
There was a problem hiding this comment.
Pick a different solution and mention it's an example. We're in aspnet/AspNetCore and that repo doesn't have an Extensions.sln file.
There was a problem hiding this comment.
Merged before I saw this feedback. I'll update in my next PR
| <Uri>https://github.com/aspnet/Extensions</Uri> | ||
| <Sha>9750bf67ab22d8d28255c6222be282f4c8e49383</Sha> | ||
| <Sha>000</Sha> |
There was a problem hiding this comment.
Suggest making this (000) and the document (000000) consistent
There was a problem hiding this comment.
This will get blown away by the next bot update (#7301). I merged this fix as is to unblock the automation that was incorrectly generating PRs to this repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow the versions in these two files is no longer aligned. The bot reads Version.Details.xml and the build uses Versions.props. If they're not aligned, this can cause the bot to not run as expected.
cc @pakrym