[blazor] Diagnostic tracing - feedback

[pavelsavara]

Changes

• splits Circuit related tracing into new CircuitActivitySource
• moves the CircuitStart trace to Microsoft.AspNetCore.Components.Server.Circuits namespace
• propagates links to other traces via ComponentsActivityLinkStore internal helper
• removes InternalsVisibleTo and it's consequences
• disconnects the traces from (SignalR) parent, so that they are top level in OTEL

Contributes to #62145
Contributes to #62254

interactive whole application

without signalR traces

side by side with SignalR

Links in the circuit trace

interactive page in non-interactive application

side by side with SignalR

non-interactive page, form submit

[javiercn]

non-interactive page, form submit

Not asking to change anything, but this is going to be interesting, since we aren't really going to see the method for the form handling events given that EditForm is the one registering them. It's always going to show up as ...HandleSubmit, but I don't see how we can do better

[javiercn]

Looks good, I have an additional suggestion for us to consider, but otherwise looks good.

[javiercn]

Looks great!

[javiercn]

Looks great!

[noahfalk]

Sorry, I know this is late, but one suggestion I missed before was to have Blazor update the DisplayName of the enclosing SignalR activity. It seems like this would avoid creating extra top-level traces while preserving the unique naming you were hoping for. For example instead of doing (conceptually):

Activity signalRActivity = Activity.Current;
Activity.Current = null;
Activity blazorActivity = ComponentActivitySource.StartActivity(...);
activity.DisplayName = $"Route {route ?? "[unknown path]"} -> {componentType ?? "[unknown component]"}";
DoBlazorWork();
activity.Stop();
Activity.Current = signalRActivity;

You could do:

Activity signalRActivity = Activity.Current;
signalRActivity.DisplayName = $"Blazor Route {route ?? "[unknown path]"} -> {componentType ?? "[unknown component]"}";
DoBlazorWork();

Thoughts?

[javiercn]

@

Sorry, I know this is late, but one suggestion I missed before was to have Blazor update the DisplayName of the enclosing SignalR activity. It seems like this would avoid creating extra top-level traces while preserving the unique naming you were hoping for. For example instead of doing (conceptually):

Activity signalRActivity = Activity.Current;
Activity.Current = null;
Activity blazorActivity = ComponentActivitySource.StartActivity(...);
activity.DisplayName = $"Route {route ?? "[unknown path]"} -> {componentType ?? "[unknown component]"}";
DoBlazorWork();
activity.Stop();
Activity.Current = signalRActivity;

You could do:

Activity signalRActivity = Activity.Current;
signalRActivity.DisplayName = $"Blazor Route {route ?? "[unknown path]"} -> {componentType ?? "[unknown component]"}";
DoBlazorWork();

Thoughts?

I don't think that would actually work. The reason being that a circuit expands more than one SignalR connection (for example when a client gets disconnected and reconnects). I realize now we might not be handling that scenario entirely correcty.