Skip to content

Enable PublishReadyToRun on LA64 and RV64 #61855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 9, 2025
Merged

Enable PublishReadyToRun on LA64 and RV64 #61855

merged 3 commits into from
May 9, 2025

Conversation

am11
Copy link
Member

@am11 am11 commented May 9, 2025

Potentially reverting #60336, since we are using host crossgen2 during the cross build.

Tested with VMR: https://github.com/am11/dotnet-riscv/actions/runs/14934033078

@github-actions github-actions bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label May 9, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label May 9, 2025
@am11
Copy link
Member Author

am11 commented May 9, 2025

cc @akoeplinger, @jkoritzinsky part 2 of dotnet/runtime#115423.

@akoeplinger akoeplinger enabled auto-merge (squash) May 9, 2025 18:27
@wtgodbe
Copy link
Member

wtgodbe commented May 9, 2025

components-e2e failure is unrelated, let me know if you want me to force-merge (the team that owns that is in Europe, so it's already their weekend)

@am11
Copy link
Member Author

am11 commented May 9, 2025

We can merge it as it's an non-disruptive. loongarch64 and riscv64 builds are only validated in runtime repo's CI, and tests are run on QEMU in GitHub actions https://github.com/am11/CrossRepoCITesting or on devices locally.


To protect this good state, I am planning to add two VMR CI build validation legs in dotnet/dotnet repo; freebsd-x64 and linux-riscv64, to cover this gap:

  1. non-MSFT supported, community, OS (freebsd) and arch (riscv64); validating that there was no accidental runtime nuget package dependency.
  2. cross build + source-build.

When we get runtime building with freebsd-riscv64, we can fold into one CI leg (covers both cross-OS && cross-Arch in one go).

@wtgodbe wtgodbe disabled auto-merge May 9, 2025 20:56
@wtgodbe wtgodbe merged commit c7415ff into dotnet:main May 9, 2025
25 of 27 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview5 milestone May 9, 2025
@am11 am11 deleted the patch-1 branch May 9, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants