Skip to content

Fixed devtools url used for debug with chrome and edge #61813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 15, 2025
Merged

Fixed devtools url used for debug with chrome and edge #61813

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d69aa55
Fixed devtools url used for debug with chrome and edge
Dona278 May 6, 2025
d4d9eaf
Simplify url normalization and added comments
Dona278 May 8, 2025
50008eb
Ignored leading slash
Dona278 May 8, 2025
d35a692
Used UriHelper to parse url and get query
Dona278 May 9, 2025
1cffd10
typo
Dona278 May 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 26 additions & 1 deletion src/Components/WebAssembly/Server/src/TargetPickerUi.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,9 +366,34 @@ private string GetDevToolsUrlWithProxy(BrowserTab tabToDebug)
{
var underlyingV8Endpoint = new Uri(tabToDebug.WebSocketDebuggerUrl);
var proxyEndpoint = new Uri(_debugProxyUrl);
var devToolsUrlAbsolute = new Uri(_browserHost + tabToDebug.DevtoolsFrontendUrl);
var devToolsUrlAbsolute = new Uri(new Uri(_browserHost), relativeUri: NormalizeDevtoolsFrontendUrl(tabToDebug.DevtoolsFrontendUrl));
var devToolsUrlWithProxy = $"{devToolsUrlAbsolute.Scheme}://{devToolsUrlAbsolute.Authority}{devToolsUrlAbsolute.AbsolutePath}?{underlyingV8Endpoint.Scheme}={proxyEndpoint.Authority}{underlyingV8Endpoint.PathAndQuery}";
return devToolsUrlWithProxy;

static string NormalizeDevtoolsFrontendUrl(string devtoolsFrontendUrl)
{
// Frontend url can be absolute or relative based on browser
string localPath;
string queryString;
if (Uri.TryCreate(devtoolsFrontendUrl, UriKind.Absolute, out var devtoolsFrontendUri))
{
localPath = devtoolsFrontendUri.LocalPath;
queryString = devtoolsFrontendUri.Query;
}
else
{
var queryStringBeginCharIndex = devtoolsFrontendUrl.IndexOf('?');
localPath = devtoolsFrontendUrl[..queryStringBeginCharIndex];
queryString = devtoolsFrontendUrl[queryStringBeginCharIndex..];
}

// We need only the last segment of the path
localPath = localPath.Split('/').Last().TrimStart('/');
// Ensure starts with "devtools"
localPath = $"devtools/{localPath}";

return $"{localPath}?{queryString}";
}
}

private string GetLaunchChromeInstructions(string targetApplicationUrl)
Expand Down
Loading