Fix SignalR server activity name #57118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
adityamandaleeka
approved these changes
Aug 1, 2024
BrennanConroy
approved these changes
Aug 1, 2024
| { | ||
| public ActivitySource ActivitySource { get; } = new ActivitySource("Microsoft.AspNetCore.SignalR.Server"); | ||
| internal const string Name = "Microsoft.AspNetCore.SignalR.Server"; | ||
| internal const string InvocationIn = $"{Name}.InvocationIn"; |
There was a problem hiding this comment.
Is this a convention or just a name we've landed on?
Would we have an "InvocationOut" in the future, for example if the server calls a client method?
Edit: I just saw we have InvocationOut on the client side PR so I think my guess was right.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Activity.OperationNameshould be a constant.Activity.DisplayNameis what OpenTelemetry uses for the span name. Dynamic value moved there.