Skip to content

[main] Update dependencies from dotnet/source-build-reference-packages #57078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 2, 2024

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jul 30, 2024

This pull request updates the following dependencies

From https://github.com/dotnet/source-build-reference-packages

  • Subscription: 34ebb389-daeb-4237-045c-08db4c01eb9e
  • Build: 20240729.2
  • Date Produced: July 29, 2024 7:31:17 PM UTC
  • Commit: 7acff95b845d4e44ac902068932076a77bfed595
  • Branch: refs/heads/main

…ence-packages build 20240729.2

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 9.0.0-alpha.1.24374.1 -> To Version 9.0.0-alpha.1.24379.2
@dotnet-maestro dotnet-maestro bot requested review from wtgodbe and a team as code owners July 30, 2024 12:42
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jul 30, 2024
Copy link
Contributor

@dotnet-policy-service dotnet-policy-service bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving dependency update.

…ence-packages build 20240729.2

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 9.0.0-alpha.1.24374.1 -> To Version 9.0.0-alpha.1.24379.2
@RussKie
Copy link
Member

RussKie commented Aug 1, 2024

.packages/microsoft.dotnet.arcade.sdk/9.0.0-beta.24375.3/tools/SourceBuild/AfterSourceBuild.proj#L81
.packages/microsoft.dotnet.arcade.sdk/9.0.0-beta.24375.3/tools/SourceBuild/AfterSourceBuild.proj(81,5): error : (NETCORE_ENGINEERING_TELEMETRY=AfterSourceBuild) 6 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/sb/prebuilt-report/baseline-comparison.xml.
See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them.
Package IDs are:
System.Composition.8.0.0
System.Composition.AttributedModel.8.0.0
System.Composition.Convention.8.0.0
System.Composition.Hosting.8.0.0
System.Composition.Runtime.8.0.0
System.Composition.TypedParts.8.0.0

@dotnet/source-build-internal could you please help? I've read https://aka.ms/dotnet/prebuilts, but I'm still unsure how to fix the issue. I tried running ".\eng\build.cmd -sb" locally and that failed:

PS D:\dotnet-aspnetcore> .\eng\build.cmd -sb

MSBUILD : error MSB1001: Unknown switch.
    Full command line: '"C:\Program Files\Microsoft Visual Studio\2022\Preview\MSBuild\Current\Bin\msbuild.exe"  /m /nologo /clp:Summary /v:minimal /nr:False /p:ContinuousIntegrationBuild=False /warnaserror /p:TreatWarningsAsErrors=true "C:\Users\user\.nuget\packages\microsoft.dotnet.arcade.sdk\9.0.0-beta.24375.3\tools\Build.proj" "/p:RepoRoot=D:\dotnet-aspnetcore\\" "-sb" "/p:Restore=True" "/p:Build=True" "/p:Pack=False" "/p:Test=False" "/p:Sign=False" "/p:Publish=False" "/p:TargetArchitecture=x64" "/p:TargetOsName=win" "/p:Configuration=Debug" "/p:BuildNative=true"'
  Switches appended by response files:
'' came from 'C:\Program Files\Microsoft Visual Studio\2022\Preview\MSBuild\Current\Bin\MSBuild.rsp'
Switch: -sb

For switch syntax, type "MSBuild -help"
Build failed with exit code 1. Check errors above.

dotnet-maestro bot and others added 2 commits August 1, 2024 12:19
…ence-packages build 20240729.2

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 9.0.0-alpha.1.24374.1 -> To Version 9.0.0-alpha.1.24379.2
@wtgodbe wtgodbe requested a review from a team as a code owner August 1, 2024 15:40
@wtgodbe
Copy link
Member

wtgodbe commented Aug 1, 2024

@RussKie all of those packages are already mentioned in eng/SourceBuildPrebuiltBaseline.xml, so we just need to update the versions to 8.0.0 to match what's incoming from source-build-reference-packages. I did that in f5b0442

@RussKie
Copy link
Member

RussKie commented Aug 2, 2024

Thank you @wtgodbe!

@RussKie RussKie merged commit ae86074 into main Aug 2, 2024
26 checks passed
@RussKie RussKie deleted the darc-main-642e7994-986a-4510-9c73-819c06266e75 branch August 2, 2024 04:26
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0-rc1 milestone Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Type: Dependency Update 🔼
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants