Use new System.Net.ServerSentEvents package in SignalR #56206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wtgodbe
approved these changes
Jun 12, 2024
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
davidfowl
reviewed
Jun 13, 2024
| try | ||
| { | ||
| while (true) | ||
| var parser = SseParser.Create(stream, (eventType, bytes) => bytes.ToArray()); |
There was a problem hiding this comment.
What's this array allocation?
There was a problem hiding this comment.
I believe the replacement for this one:
https://github.com/dotnet/aspnetcore/pull/56206/files#diff-df980831669d2f5d4809a2d65ee1189391814d4f594f465fe81fb5f9bdc6c629L98
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main differences:
\ris handled now, before we didn't add support for just\rCancelPendingRead()to trigger cancellation, now we get anOperationCanceledExceptionFormatExceptionis no longer thrown when a partial message is received and the HTTP request is done. I believe that is more spec compliant.\ncharacter is inserted into the final message between each data frame. Our old implementation usedEnvironment.NewLinebut the spec mentions\n