Skip to content

Override IOQueueCount via env vars #51964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

EgorBo
Copy link
Member

@EgorBo EgorBo commented Nov 9, 2023

This PR adds ability to change default value for Socket.IOQueueCount in Kestrel - this will allow us to easily experiment with the default value on various many-cores system (or with different affinity settings) before we propose a better default here.

E.g. Current RPS on a many-cores arm64 CPU affinitized to 16 cores: 1.2M RPS (Windows)
Same setup with ASPNETCORE_IOQUEUECOUNT=10: 1.8M RPS.

cc @sebastienros

@ghost ghost added the area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions label Nov 9, 2023
@davidfowl
Copy link
Member

This should use our configuration system, not direct environment variables

@EgorBo
Copy link
Member Author

EgorBo commented Nov 9, 2023

This should use our configuration system, not direct environment variables

Can you please point me to an example?

@BrennanConroy
Copy link
Member

It's also configurable via UseSockets

@amcasey
Copy link
Member

amcasey commented Nov 15, 2023

It's not perfectly analogous, but here's an example of consuming new env vars: #44194

@ghost
Copy link

ghost commented Nov 23, 2023

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no conflicting changes have occurred, please rerun validation before merging. You can do this by leaving an /azp run comment here (requires commit rights), or by simply closing and reopening.

@ghost ghost added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Nov 23, 2023
@EgorBo
Copy link
Member Author

EgorBo commented Nov 27, 2023

Thanks! will configure with code

@EgorBo EgorBo closed this Nov 27, 2023
@ghost
Copy link

ghost commented Nov 27, 2023

Hi @EgorBo. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants