-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Run components E2E tests in CI #5158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run components E2E tests in CI #5158
Conversation
I'm unclear on how to know whether this is passing or not.
It doesn't really matter right now though. Since this is a whole new category of tests, I was planning to wait until January before merging to |
3892f70
to
10253ee
Compare
Looks like the PR validation and aspnetci builds aren't running unit tests currently anyway, so there isn't anything else to verify about this now. It does work locally and AFAIK should work the same in CI. @rynowak @javiercn @natemcmaster If one of you could CR this so I can merge that would be great - thanks! |
This change is making tests hang on OSX. |
With a 30 second re-try per test 😄 |
I think we need to revert this if we can fix this soon. All PR checks on master are failing because they exceed the build timeout. |
This is to find out which of our various CI test runners are ready to run the Components' Selenium-based E2E tests.
If they all run them flawlessly we could merge this as-is. If not, I'll close this PR and investigate further.