Add namespace and assembly check before interception #51243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
captainsafia
requested review from
Tratcher,
BrennanConroy and
halter73
as code owners
ghost
added
the
area-networking
BrennanConroy
approved these changes
Oct 9, 2023
src/Http/Http.Extensions/test/RequestDelegateGenerator/CompileTimeCreationTests.cs
Outdated
Show resolved
Hide resolved
|
|
||
| public static class EndpointRouteBuilderExtensions | ||
| { | ||
| public static IServiceProvider Map(this IServiceProvider app, int id, Delegate requestDelegate) |
There was a problem hiding this comment.
Another nit: Should use the exact same signature as Map
public static IEndpointConventionBuilder Map(
this IEndpointRouteBuilder endpoints,
RoutePattern pattern,
RequestDelegate requestDelegate)
There was a problem hiding this comment.
Based on the overload resolution rules for extension methods, the compiler will bind to the methods defined in the framework if they have the same signature. I did update the tests to include a scenario with extension methods targeting IEndpointRouteBuilder and a different type for the second parameter.
|
/backport to release/8.0 |
|
Started backporting to release/8.0: https://github.com/dotnet/aspnetcore/actions/runs/6475214573 |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #51233