Support independently enabling hosting event counters and metrics

[JamesNK]

Addresses #50412

This allows hosting event counters and metrics to be independently enabled. If only metrics are enabled, then the event source Interlocked calls are skipped. However, there is no performance improvement if both event counters and metrics are enabled.

[adityamandaleeka]

LGTM. Can you please try the crank command they're using and see what the results look like? @EgorBo posted it in the issue.

cc @JulieLeeMSFT

[adityamandaleeka]

BTW this is approved for 8.0, pending confirmation from @JulieLeeMSFT or @EgorBo that it meets their needs.

[JamesNK]

LGTM. Can you please try the crank command they're using and see what the results look like? @EgorBo posted it in the issue.

If there an easy way to run that command on the PR changes?

[adityamandaleeka]

Check out --[JOB].source.branchOrCommit here: https://github.com/dotnet/crank/blob/main/src/Microsoft.Crank.Controller/README.md

I think that may do it...

[noahfalk]

👍

[davidfowl]

This gets allocated per request when metrics are on?

[JamesNK]

It’s cached on the context

[JulieLeeMSFT]

Thanks for the quick fix!!

[adityamandaleeka]

@JamesNK Ready for merge?

[JamesNK]

Yes

[EgorBo]

Is it going to be backported to 8.0 ?

[JamesNK]

Is it going to be backported to 8.0 ?

Yes. This PR is on the release/8.0 branch. aspnetcore is automatically forward merging to main.

[EgorBo]

it seesm that it didn't help with the initial issue:

crank --config https://raw.githubusercontent.com/aspnet/Benchmarks/main/scenarios/json.benchmarks.yml --config https://raw.githubusercontent.com/aspnet/Benchmarks/main/build/azure.profile.yml --config https://raw.githubusercontent.com/aspnet/Benchmarks/main/scenarios/steadystate.profile.yml --config https://raw.githubusercontent.com/aspnet/Benchmarks/main/build/ci.profile.yml --scenario json --profile arm-lin-28-app --profile intel-load2-load --application.framework net8.0 --application.collectDependencies true --application.options.collectCounters true --application.options.counterProviders "Microsoft.AspNetCore.Hosting"

still 2x slow, it uses aspnet from this commit: a413f2e0f8ec (yesterday) so presumably includes this fix.
cc @JamesNK

[ghost]

Hi @EgorBo. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

[davidfowl]

It wouldn't fix the issue because crank uses event counters and we did nothing to improve the usage of interlocked.