Clean up some code in ANCM #49718
Merged
Clean up some code in ANCM #49718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityamandaleeka
requested review from
Tratcher,
halter73,
BrennanConroy,
JamesNK and
mgravell
as code owners
ghost
added
the
| } | ||
| else if (struPath.QueryStr()[dwPosition-1] == L':') | ||
|
|
||
| if (struPath.QueryStr()[position - 1] == L':') |
There was a problem hiding this comment.
You removed the position == 0 condition so this one can buffer underrun now
There was a problem hiding this comment.
I removed it because it can never be 0. Can it? Even in the case where we start at 0, the STRU::IndexOf is given the start offset of position+1 to search from, and it will either return -1 (if not found) or a position >=1.
There was a problem hiding this comment.
Oh, I guess. Probably add a comment then since it wasn't obvious from first glance
BrennanConroy
approved these changes
Jul 31, 2023
| HRESULT | ||
| FILE_UTILITY::EnsureDirectoryPathExist( | ||
| _In_ LPCWSTR pszPath | ||
| FILE_UTILITY::EnsureDirectoryPathExists( |
There was a problem hiding this comment.
Need to change the header and caller
There was a problem hiding this comment.
Yea, I used the VS refactor thing and forgot to save the other modified files 😆
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaning up some stuff I noticed while I was looking into ANCM code. This includes some dead code removal, fixing weird conditionals, removing some gotos, etc.
This is pure cleanup and should have no functional impact.
cc: @BrennanConroy