-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Retry failing helix test #48694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retry failing helix test #48694
Conversation
`Http2WebSocketTests.HEADERS_Received_SecondRequest_ConnectProtocolReset` failed in #48664
Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at. |
Issue? Link to failure? |
Sorry, a bit rushed today. Failure: https://github.com/dotnet/aspnetcore/runs/14144482654 Was I supposed to file a corresponding issue? I didn't notice that in the handbook instructions. |
Hi @amcasey. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
My reading of these steps was, don't follow the quarantine procedure (including filing an issue and adding an attribute) if you can add it to the retry list. I agree that it's a little weird that there will be no (apparent?) follow-up if the test passes on retry. |
Hi @amcasey. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
It's possible the instructions changed. The whole retry thing is kind of new (and I'm not a fan of it anyways 😆) Also, that failure looks very similar to the PR Will pinged us on yesterday... |
That was in |
Hi @amcasey. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
Http2WebSocketTests.HEADERS_Received_SecondRequest_ConnectProtocolReset
failed in #48664