Skip to content

Retry failing helix test #48694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2023
Merged

Retry failing helix test #48694

merged 1 commit into from
Jun 9, 2023

Conversation

amcasey
Copy link
Member

@amcasey amcasey commented Jun 9, 2023

Http2WebSocketTests.HEADERS_Received_SecondRequest_ConnectProtocolReset failed in #48664

`Http2WebSocketTests.HEADERS_Received_SecondRequest_ConnectProtocolReset` failed in #48664
@amcasey amcasey requested review from a team and wtgodbe as code owners June 9, 2023 18:24
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jun 9, 2023
@ghost
Copy link

ghost commented Jun 9, 2023

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

@amcasey amcasey enabled auto-merge (squash) June 9, 2023 18:58
@amcasey amcasey merged commit c55ee62 into main Jun 9, 2023
@amcasey amcasey deleted the amcasey-patch-1 branch June 9, 2023 20:01
@ghost ghost added this to the 8.0-preview6 milestone Jun 9, 2023
@BrennanConroy
Copy link
Member

Issue? Link to failure?

@amcasey
Copy link
Member Author

amcasey commented Jun 9, 2023

Sorry, a bit rushed today. Failure: https://github.com/dotnet/aspnetcore/runs/14144482654

Was I supposed to file a corresponding issue? I didn't notice that in the handbook instructions.

@ghost
Copy link

ghost commented Jun 9, 2023

Hi @amcasey. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

@amcasey
Copy link
Member Author

amcasey commented Jun 9, 2023

My reading of these steps was, don't follow the quarantine procedure (including filing an issue and adding an attribute) if you can add it to the retry list. I agree that it's a little weird that there will be no (apparent?) follow-up if the test passes on retry.

@ghost
Copy link

ghost commented Jun 9, 2023

Hi @amcasey. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

@BrennanConroy
Copy link
Member

Was I supposed to file a corresponding issue? I didn't notice that in the handbook instructions.

It's possible the instructions changed. The whole retry thing is kind of new (and I'm not a fan of it anyways 😆)

Also, that failure looks very similar to the PR Will pinged us on yesterday...

@amcasey
Copy link
Member Author

amcasey commented Jun 9, 2023

Also, that failure looks very similar to the PR Will pinged us on yesterday...

That was in release/6.0 and I was unable to repro it in main. Fair point though.

@ghost
Copy link

ghost commented Jun 9, 2023

Hi @amcasey. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants