Skip to content

Minor debugging visualizer cleanup #48632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 7, 2023
Merged

Minor debugging visualizer cleanup #48632

merged 1 commit into from
Jun 7, 2023

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Jun 6, 2023

  • Only display client certificate if present. Most apps don't use client certificates
  • Boolean is lowercase in debug strings. Make web socket DebuggerToString consistent.

@JamesNK JamesNK enabled auto-merge (squash) June 7, 2023 01:55
@JamesNK JamesNK merged commit b97a36e into main Jun 7, 2023
@JamesNK JamesNK deleted the jamesnk/debugging-cleanup branch June 7, 2023 03:26
@ghost ghost added this to the 8.0-preview6 milestone Jun 7, 2023
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danmoseley danmoseley danmoseley approved these changes

@amcasey amcasey amcasey approved these changes

@Tratcher Tratcher Awaiting requested review from Tratcher

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

@captainsafia captainsafia Awaiting requested review from captainsafia captainsafia is a code owner

Assignees
No one assigned
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Milestone
8.0-preview6
Development

Successfully merging this pull request may close these issues.
3 participants
@JamesNK @danmoseley @amcasey